From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Ilya Leoshkevich via Gdb-patches <gdb-patches@sourceware.org>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH] gdb: support rseq auxvs
Date: Fri, 6 Oct 2023 21:30:45 -0400 [thread overview]
Message-ID: <ed6e1865-d832-46be-9b70-c4234f90490d@simark.ca> (raw)
In-Reply-To: <875y3nzfvd.fsf@tromey.com>
On 10/3/23 15:05, Tom Tromey wrote:
>>>>>> "Ilya" == Ilya Leoshkevich via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Ilya> Linux kernel commit commit 317c8194e6ae ("rseq: Introduce feature size
> Ilya> and alignment ELF auxiliary vector entries") introduced two new auxvs:
> Ilya> AT_RSEQ_FEATURE_SIZE and AT_RSEQ_ALIGN. Support them in GDB. This
> Ilya> fixes auxv.exp on kernels >= v6.3.
>
> Thank you for the patch. I didn't see a review of this. The patch
> looks good to me.
>
> Can you add this trailer the commit?
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30540
>
> Thanks.
>
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
I stumbled on this problem, so I went ahead and pushed the patch. I
made a little change, I used AUXV_FORMAT_DEC for both values, I think
it's more natural.
Simon
prev parent reply other threads:[~2023-10-07 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 23:03 Ilya Leoshkevich
2023-10-03 19:05 ` Tom Tromey
2023-10-07 1:30 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6e1865-d832-46be-9b70-c4234f90490d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=iii@linux.ibm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).