From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Move -lsocket check to common.m4
Date: Thu, 12 Oct 2023 19:32:47 +0100 [thread overview]
Message-ID: <edeb3530-9722-4d56-b4f1-f4770b519972@palves.net> (raw)
In-Reply-To: <87zg0qv2mv.fsf@tromey.com>
On 2023-10-10 17:55, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> A user pointed out that the -lsocket check in gdb should also apply to
> Tom> gdbserver -- otherwise it can't find the Solaris socketpair. This
> Tom> patch makes the change. It also removes a couple of redundant
> Tom> function checks from gdb's configure.ac.
>
> Tom> This was tested by the person who reported the bug.
>
> BTW this one should probably also go on the GDB 14 branch.
> It seems pretty safe, IMO, and it fixes a Solaris build problem.
Agreed, for both branches:
Approved-By: Pedro Alves <pedro@palves.net>
prev parent reply other threads:[~2023-10-12 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 13:24 Tom Tromey
2023-10-10 16:55 ` Tom Tromey
2023-10-12 18:32 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edeb3530-9722-4d56-b4f1-f4770b519972@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).