Re: [PATCH] Add name_of_main and language_of_main to the DWARF index

[Tom de Vries <tdevries@suse.de>]

On 7/7/23 17:00, Matheus Branco Borella via Gdb-patches wrote:
> Is there anything else I'm missing?

There seem to be a lot of white space issues:
...
$ git show --pretty=%s --check | grep -v '^\+'
Add name_of_main and language_of_main to the DWARF index

gdb/dwarf2/index-write.c:1084: indent with spaces.
gdb/dwarf2/index-write.c:1206: indent with spaces.
gdb/dwarf2/index-write.c:1217: indent with spaces.
gdb/dwarf2/index-write.c:1218: indent with spaces.
gdb/dwarf2/index-write.c:1219: indent with spaces.
gdb/dwarf2/index-write.c:1221: indent with spaces.
gdb/dwarf2/index-write.c:1222: indent with spaces.
gdb/dwarf2/index-write.c:1223: indent with spaces.
gdb/dwarf2/read-gdb-index.c:622: indent with spaces.
gdb/dwarf2/read-gdb-index.c:777: trailing whitespace.
gdb/dwarf2/read-gdb-index.c:778: indent with spaces.
gdb/dwarf2/read-gdb-index.c:791: indent with spaces.
gdb/dwarf2/read-gdb-index.c:803: trailing whitespace.
gdb/dwarf2/read-gdb-index.c:804: trailing whitespace, indent with spaces.
gdb/dwarf2/read-gdb-index.c:805: indent with spaces.
gdb/dwarf2/read.h:248: trailing whitespace.
gdb/dwarf2/read.h:251: trailing whitespace.
gdb/dwarf2/read.h:252: trailing whitespace.
...

Furthermore, I can confirm that this fixes regressions with target board 
gdb-index in test-cases:
- gdb.fortran/backtrace.exp 

- gdb.fortran/info-main.exp 

- gdb.dwarf2/main-subprogram.exp 

- gdb.fortran/mixed-lang-stack.exp

Some of those are KFAIL-ed for 
https://sourceware.org/bugzilla/show_bug.cgi?id=24549 .

So, you could add this to the commit message:
...
PR symtab/24549
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24549
...

Thanks,
- Tom