Re: [PATCH] gdb/elfread.c: Add plt symbol check for _PROCEDURE_LINKAGE_TABLE_

[Hui Li <lihui@loongson.cn>]

On 2023/3/25 上午12:16, Tom Tromey wrote:
>>>>>> Hui Li <lihui@loongson.cn> writes:
> 
>> This is because some architectures such as LoongArch define the symbol
>> _PROCEDURE_LINKAGE_TABLE_ at the start of the .plt section. Add plt
>> symbol check for _PROCEDURE_LINKAGE_TABLE_ to improved the judgment of
>> plt symbol and to get correct target function address of STT_GNU_IFUNC.
> 
> It would be helpful to know how precisely things go wrong.
> The patch itself seems reasonable enough -- hacky maybe but not out of
> the ordinary way -- but I don't understand how it relates to the problem.
> Like, why does ignoring this symbol here affect the results?
> 
> Tom
> 

Thanks for your review.

This is a minor fix for one of the subfunction about ifunc.
The principle of ifunc and its implementation in gdb are not
explained in detail. So it's hard to understand how it relates
to the problem.

I change the commit message to explain this process in detail,
and send V2.
https://sourceware.org/pipermail/gdb-patches/2023-March/198303.html

Thanks.
Hui