From: Tom Tromey <tom@tromey.com>
To: Hui Li <lihui@loongson.cn>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/elfread.c: Add plt symbol check for _PROCEDURE_LINKAGE_TABLE_
Date: Fri, 24 Mar 2023 10:16:44 -0600 [thread overview]
Message-ID: <87pm8ydt03.fsf@tromey.com> (raw)
In-Reply-To: <20230323075908.23013-1-lihui@loongson.cn> (Hui Li's message of "Thu, 23 Mar 2023 15:59:08 +0800")
>>>>> Hui Li <lihui@loongson.cn> writes:
> This is because some architectures such as LoongArch define the symbol
> _PROCEDURE_LINKAGE_TABLE_ at the start of the .plt section. Add plt
> symbol check for _PROCEDURE_LINKAGE_TABLE_ to improved the judgment of
> plt symbol and to get correct target function address of STT_GNU_IFUNC.
It would be helpful to know how precisely things go wrong.
The patch itself seems reasonable enough -- hacky maybe but not out of
the ordinary way -- but I don't understand how it relates to the problem.
Like, why does ignoring this symbol here affect the results?
Tom
next prev parent reply other threads:[~2023-03-24 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 7:59 Hui Li
2023-03-24 16:16 ` Tom Tromey [this message]
2023-03-27 9:39 ` Hui Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm8ydt03.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=lihui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).