From: Keith Seitz <keiths@redhat.com>
To: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix doc build dependencies for --with-system-readline
Date: Mon, 13 Feb 2023 07:01:37 -0800 [thread overview]
Message-ID: <ef02eec4-fcc5-dcb9-8598-aa43ad3ce305@redhat.com> (raw)
In-Reply-To: <871qmwgp9s.fsf@tromey.com>
On 2/11/23 08:06, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Keith> PR build/30108 concerns building gdb documentation with
> Keith> --with-sytem-readline. If the in-tree readline directory is
> Keith> missing, though, the docs will fail to build:
>
> ...
> Keith> This patch fixes this by creating (essentially) a conditional setting of the
> Keith> dependencies to be included from readline.
>
> Thanks, this is ok.
> Approved-By: Tom Tromey <tom@tromey.com>
Thank you for the review; I've pushed this and cherry-picked it
for gdb-13-branch (as requested by Joel).
Keith
next prev parent reply other threads:[~2023-02-13 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 21:42 Keith Seitz
2023-02-11 16:06 ` Tom Tromey
2023-02-13 15:01 ` Keith Seitz [this message]
2023-02-12 11:36 ` Joel Brobecker
2023-02-13 15:02 ` Keith Seitz
2023-02-15 8:02 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef02eec4-fcc5-dcb9-8598-aa43ad3ce305@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).