From: Luis Machado <luis.machado@arm.com>
To: "Pedro Alves" <pedro@palves.net>,
"Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v4] gdb/arm: Stop unwinding on error, but do not assert
Date: Fri, 14 Oct 2022 13:03:59 +0100 [thread overview]
Message-ID: <eff4abe8-8b17-1f1d-69c0-159b52d19b39@arm.com> (raw)
In-Reply-To: <6d3e2120-15bf-25e6-8914-8ec5b6e67976@palves.net>
On 10/14/22 12:45, Pedro Alves wrote:
> On 2022-10-13 7:11 p.m., Torbjörn SVENSSON wrote:
>> When it's impossible to read the FPCCR and XPSR, the unwinding is
>> unpredictable as the it's not possible to determine the correct
>> frame size or padding.
>> The only sane thing to do in this condition is to stop the unwinding.
>>
>> Example session wihtout this patch:
>
> wihtout -> without
>
> Thank you, this version LGTM. This way, there's a better chance gdb can
> distinguish different "outermost" frames, e.g., for watchpoints on local vars,
> or for stepping from a "broken" frame, to another "broken" frame.
>
> I'll defer final approval to Luis.
>
> Reviewed-by: Pedro Alves <pedro@palves.net>
LGTM.
next prev parent reply other threads:[~2022-10-14 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 18:11 Torbjörn SVENSSON
2022-10-14 11:45 ` Pedro Alves
2022-10-14 11:47 ` Torbjorn SVENSSON
2022-10-14 12:03 ` Luis Machado [this message]
2022-10-14 13:32 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff4abe8-8b17-1f1d-69c0-159b52d19b39@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).