Re: [PATCH 1/2] Add lld(linker) specific option.

[Simon Marchi <simark@simark.ca>]

On 2022-03-21 08:15, Balasubrmanian, Vignesh via Gdb-patches wrote:
>
> Please review the attached patch.
>
> LLD doesn't have the option "-Ttext-segment" but "--image-base".
> So first try using "-Ttext-segment". If it fails, try the lld option "--image-base" before failing.
>
> Thanks,
> vigneshbalu
>
>

Hi,

The approach looks ok to me.

Grepping for "text-segment", I see three other tests using
-Ttext-segment, are we going to need to fix those up too?

 - gdb.base/execl-update-breakpoints.exp
 - gdb.arch/arm-bl-branch-dest.exp
 - gdb.threads/step-over-exec.exp

If so, it would be interesting to make this an option to gdb_compile,
instead of specifying a linker-specific flag.  For example, you'd use:

       set options [list \
            additional_flags=-DFUNCTION_NAME=[format "jit_function_%04d" $i] \
	    text_segment=$addr]

and text_segment would be recognized by gdb_compile and the complexity
would be hidden there.

Can you mention (here and in the commit message) the full "make check"
line you use to test this?

Simon