From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Balasubrmanian, Vignesh" <Vignesh.Balasubrmanian@amd.com>,
Simon Marchi <simark@simark.ca>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
"Kumar N, Bhuvanendra" <Bhuvanendra.KumarN@amd.com>
Subject: Re: [PATCH 1/2] Add lld(linker) specific option.
Date: Tue, 29 Mar 2022 08:23:46 -0400 [thread overview]
Message-ID: <6cd77dc1-27fc-deef-0d2c-3a8fc1df9ca5@polymtl.ca> (raw)
In-Reply-To: <83fea526-a710-4eca-9c62-2bd1b0dc6f13@polymtl.ca>
> Like Luis said, I see some failures when running the test with the lld
> linker, do you see those too? If so, it would be good to mention it in
> the commit message, so that others aren't surprised to see the test case
> fail. Getting the test case to compile is already an improvement.
Oh, fixing the test is done in patch #2, right? If so, you can mention
in the commit message that after this patch (patch #1), the test fails,
but it is fixed by the subsequent patch.
Simon
next prev parent reply other threads:[~2022-03-29 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 12:15 Balasubrmanian, Vignesh
2022-03-21 13:44 ` Simon Marchi
2022-03-22 16:21 ` Balasubrmanian, Vignesh
2022-03-29 8:35 ` Luis Machado
2022-03-29 12:21 ` Simon Marchi
2022-03-29 12:23 ` Simon Marchi [this message]
2022-03-30 11:21 ` Balasubrmanian, Vignesh
2022-04-18 14:27 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cd77dc1-27fc-deef-0d2c-3a8fc1df9ca5@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=Bhuvanendra.KumarN@amd.com \
--cc=JiniSusan.George@amd.com \
--cc=Vignesh.Balasubrmanian@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).