From: Luis Machado <luis.machado@arm.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Handle missing .note.GNU-stack
Date: Thu, 20 Oct 2022 01:27:32 +0100 [thread overview]
Message-ID: <f2407145-80ab-fedd-2cf1-2b09168ca48e@arm.com> (raw)
In-Reply-To: <3ea58523-bc8d-f055-2d18-37fefec13e3f@suse.de>
Hi,
On 10/19/22 19:54, Tom de Vries wrote:
> On 10/12/22 16:53, Tom de Vries wrote:
>> diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.S b/gdb/testsuite/gdb.arch/arm-disp-step.S
>> index b67e83e56e0..3cfb6063f40 100644
>> --- a/gdb/testsuite/gdb.arch/arm-disp-step.S
>> +++ b/gdb/testsuite/gdb.arch/arm-disp-step.S
>> @@ -391,3 +391,4 @@ test_add_rn_pc_end:
>> bx lr
>> .size test_add_rn_pc, .-test_add_rn_pc
>> #endif
>> + .section .note.GNU-stack,"",@progbits
>
> Hi,
>
> I realize now that this'll probably need to be:
> ...
> + .section .note.GNU-stack,"",%progbits
> ...
> and the same for the dwarf assembly test-cases when using target arm*
>
> See f.i. 9a5911c08be ("gdb/testsuite/gdb.dwarf2: Replace @ with % for ARM compatability.")
>
> What I cannot figure out if that holds as well for aarch64 archs: does that one also use %progbits instead of @progbits?
>
> Luis, do you happen to know?
From what I see on aarch64, it uses @progbits.
.section .debug_info,"",@progbits
next prev parent reply other threads:[~2022-10-20 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:53 Tom de Vries
2022-10-19 18:54 ` Tom de Vries
2022-10-20 0:27 ` Luis Machado [this message]
2022-10-25 12:15 ` [committed][gdb/testsuite] " Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2407145-80ab-fedd-2cf1-2b09168ca48e@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).