public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org, Luis Machado <luis.machado@arm.com>
Subject: Re: [PATCH][gdb/testsuite] Handle missing .note.GNU-stack
Date: Wed, 19 Oct 2022 20:54:25 +0200	[thread overview]
Message-ID: <3ea58523-bc8d-f055-2d18-37fefec13e3f@suse.de> (raw)
In-Reply-To: <20221012145323.GA3743@delia.home>

On 10/12/22 16:53, Tom de Vries wrote:
> diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.S b/gdb/testsuite/gdb.arch/arm-disp-step.S
> index b67e83e56e0..3cfb6063f40 100644
> --- a/gdb/testsuite/gdb.arch/arm-disp-step.S
> +++ b/gdb/testsuite/gdb.arch/arm-disp-step.S
> @@ -391,3 +391,4 @@ test_add_rn_pc_end:
>   	bx lr
>   	.size test_add_rn_pc, .-test_add_rn_pc
>   #endif
> +	.section	.note.GNU-stack,"",@progbits

Hi,

I realize now that this'll probably need to be:
...
+	.section	.note.GNU-stack,"",%progbits
...
and the same for the dwarf assembly test-cases when using target arm*

See f.i. 9a5911c08be ("gdb/testsuite/gdb.dwarf2: Replace @ with % for 
ARM compatability.")

What I cannot figure out if that holds as well for aarch64 archs: does 
that one also use %progbits instead of @progbits?

Luis, do you happen to know?

Thanks,
- Tom

  reply	other threads:[~2022-10-19 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 14:53 Tom de Vries
2022-10-19 18:54 ` Tom de Vries [this message]
2022-10-20  0:27   ` Luis Machado
2022-10-25 12:15     ` [committed][gdb/testsuite] " Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ea58523-bc8d-f055-2d18-37fefec13e3f@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).