public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH][gdb/testsuite] Fix printing of 0x10000000000000000
Date: Mon, 23 May 2022 13:26:10 +0200	[thread overview]
Message-ID: <f2b07e89-af3f-b526-0fbb-a95b9cb755dc@suse.de> (raw)
In-Reply-To: <87v8u1icjk.fsf@redhat.com>

On 5/19/22 20:48, Andrew Burgess wrote:
> Maybe you're working on modula-2 right now, in which case, ignore this.
> But, if you're not, then it might be better to raise a bug for the
> module-2 issues - even if it's just "parse_number needs a rewrite", and
> then use setup_xfail here instead of continue.
> 

I filed:
- https://sourceware.org/bugzilla/show_bug.cgi?id=29163
   "[gdb/m2] parse_number needs rewrite"
listing two UB errors.

And then submitted this ( 
https://sourceware.org/pipermail/gdb-patches/2022-May/189313.html ) to 
fix those.

> But otherwise, this all looks OK to me.

Thanks for the review.

I've now resubmitted in a slightly different format:
- one patch to increase test coverage in gdb.base/parse_number.exp
- patches for each language to address all exposes issues.

I'm hoping that the per-language patches will be easier to review.

Thanks,
- Tom

      reply	other threads:[~2022-05-23 11:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 12:25 Tom de Vries
2022-05-19 18:48 ` Andrew Burgess
2022-05-23 11:26   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2b07e89-af3f-b526-0fbb-a95b9cb755dc@suse.de \
    --to=tdevries@suse.de \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).