[PATCH] [AArch64] Remove unused DWARF PAUTH registers

[PATCH] [AArch64] Remove unused DWARF PAUTH registers

[Luis Machado]

The AARCH64_DWARF_PAUTH_DMASK and AARCH64_DWARF_PAUTH_CMASK DWARF registers
never made their way into the aadwarf64. The following patch removes these
constants and their use.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=26295
---
 gdb/aarch64-tdep.c | 3 ---
 gdb/aarch64-tdep.h | 2 --
 2 files changed, 5 deletions(-)

diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index d85c406069b..d0995bb9c48 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -2236,9 +2236,6 @@ aarch64_dwarf_reg_to_regnum (struct gdbarch *gdbarch, int reg)
 
   if (tdep->has_pauth ())
     {
-      if (reg >= AARCH64_DWARF_PAUTH_DMASK && reg <= AARCH64_DWARF_PAUTH_CMASK)
-	return tdep->pauth_reg_base + reg - AARCH64_DWARF_PAUTH_DMASK;
-
       if (reg == AARCH64_DWARF_RA_SIGN_STATE)
 	return tdep->ra_sign_state_regnum;
     }
diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 9ca3aee1ed1..057525e68f4 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -35,8 +35,6 @@ struct regset;
 #define AARCH64_DWARF_X0   0
 #define AARCH64_DWARF_SP  31
 #define AARCH64_DWARF_RA_SIGN_STATE  34
-#define AARCH64_DWARF_PAUTH_DMASK  35
-#define AARCH64_DWARF_PAUTH_CMASK  36
 #define AARCH64_DWARF_V0  64
 #define AARCH64_DWARF_SVE_VG   46
 #define AARCH64_DWARF_SVE_FFR  47
-- 
2.25.1

Re: [PATCH] [AArch64] Remove unused DWARF PAUTH registers

[Tom Tromey]

>>>>> Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:

> The AARCH64_DWARF_PAUTH_DMASK and AARCH64_DWARF_PAUTH_CMASK DWARF registers
> never made their way into the aadwarf64. The following patch removes these
> constants and their use.

> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=26295

I don't know the details of this arch but based on the bug, this looks
good to me.  Thank you.

Tom

Re: [PATCH] [AArch64] Remove unused DWARF PAUTH registers

[Luis Machado]

On 5/16/22 16:27, Tom Tromey wrote:
>>>>>> Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> The AARCH64_DWARF_PAUTH_DMASK and AARCH64_DWARF_PAUTH_CMASK DWARF registers
>> never made their way into the aadwarf64. The following patch removes these
>> constants and their use.
> 
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=26295
> 
> I don't know the details of this arch but based on the bug, this looks
> good to me.  Thank you.
> 
> Tom

Thanks. Pushed now.