Re: [PATCH, v2] [AArch64] MTE corefile support

[Luis Machado <luis.machado@arm.com>]

Hi Eli,

On 4/21/22 16:52, Eli Zaretskii wrote:
>> Date: Thu, 21 Apr 2022 16:20:40 +0100
>> NoDisclaimer: true
>> From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
>>
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index 760cb2b7abc..885b3929d84 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -3,6 +3,10 @@
>>   
>>   *** Changes since GDB 12
>>   
>> +* GDB now supports dumping memory tag data for AArch64 MTE.  It also supports
>> +  reading memory tag data for AArch64 MTE from core files generated by
>> +  the gcore command or the Linux kernel.
>> +
> 
> I think this should say something about the significance of this
> feature.  Otherwise it is completely unclear why would GDB want to
> support that.
> 
> Same comment for the addition to the manual.
> 
> Thanks.

It is a bit short. How about the following additional paragraph?

"When a process uses memory-mapped pages protected by memory tags (for 
example, AArch64 MTE), this additional information will be recorded in 
the core file in the event of a crash or if GDB generates a core file 
from the current process state.

The memory tag data will be used so developers can display the memory 
tags from a particular memory region, and will also be used to show a 
detailed message about a crash that happened due to a memory tag violation."