Re: [PATCH 1/2] [AArch64] MTE corefile support

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 22 Apr 2022 14:27:15 +0100
> From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 760cb2b7abc..d6818d54972 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,16 @@
>  
>  *** Changes since GDB 12
>  
> +* GDB now supports dumping memory tag data for AArch64 MTE.  It also supports
> +  reading memory tag data for AArch64 MTE from core files generated by
> +  the gcore command or the Linux kernel.
> +
> +  When a process uses memory-mapped pages protected by memory tags (for
> +  example, AArch64 MTE), this additional information will be recorded in
> +  the core file in the event of a crash or if GDB generates a core file
> +  from the current process state.  GDB will show this additional information
> +  automatically, or through one of the memory-tag subcommands.
> +

This part is OK.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index c1e9b09e833..d9021f1c56d 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -25545,6 +25545,24 @@ options that can be controlled at runtime and emulates the @code{prctl}
>  option @code{PR_SET_TAGGED_ADDR_CTRL}.  For further information, see the
>  documentation in the Linux kernel.
>  
> +@value{GDBN} supports dumping memory tag data to core files through the
> +@command{gcore} command and reading memory tag data from core files generated
> +by the @command{gcore} command or the Linux kernel.
> +
> +When a process uses memory-mapped pages protected by memory tags (for
> +example, AArch64 MTE), this additional information will be recorded in
> +the core file in the event of a crash or if @value{GDB} generates a core file
> +from the current process state.
> +
> +The memory tag data will be used so developers can display the memory
> +tags from a particular memory region (using the @samp{m} modifier to the
> +@command{x} command, using the @command{print} command or using the various
> +@command{memory-tag} subcommands.

Please add here cross-references to where the respective commands are
described.

The documentation parts are okay with that nit fixed.

Thanks.