public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Carl Love <cel@linux.ibm.com>
To: Tom Tromey <tom@tromey.com>, Carl Love <cel@linux.ibm.com>
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] rs6000, unwind-on-each-instruction fix.
Date: Thu, 8 Feb 2024 11:37:57 -0800	[thread overview]
Message-ID: <f53b5665-8532-48b5-a8ef-808877c80df0@linux.ibm.com> (raw)
In-Reply-To: <87sf22945o.fsf@tromey.com>

Tom:

On 2/8/24 10:55, Tom Tromey wrote:
>>>>>> "Carl" == Carl Love <cel@linux.ibm.com> writes:
> 
> Carl> The patch fixes all 10 regression failures for the test.  The patch
> Carl> has been tested on Power 9 and Power 10 with no additional regression
> Carl> test failures.
> 
> Carl> Please let me know if this patch is acceptable to GDB mainline.
> 
> I think it would be best if someone familiar with PPC reviewed this.
> 
> FWIW it looks reasonable to me.
> 
> Carl> +      /* The PC is found in the link register.  */
> Carl> +      cache->saved_regs[gdbarch_pc_regnum (gdbarch)] =
> Carl> +	cache->saved_regs[tdep->ppc_lr_regnum];
> 
> Here the '=' should go on the 2nd line.

Yes, the "=" is on the wrong line.  I fixed it locally.  Thanks for catching
that.  

Hopefully Ulrich will get a chance to look at the patch.  I think he
was out of the office for a few days.  I am thinking the patch got overlooked
with all of his other mail.  

                     Carl 

  reply	other threads:[~2024-02-08 19:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 21:35 Carl Love
2024-02-08 16:23 ` PING " Carl Love
2024-02-08 18:55 ` Tom Tromey
2024-02-08 19:37   ` Carl Love [this message]
2024-02-12  9:55 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f53b5665-8532-48b5-a8ef-808877c80df0@linux.ibm.com \
    --to=cel@linux.ibm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).