From: Carl Love <cel@us.ibm.com>
To: Luis Machado <luis.machado@arm.com>,
Bruno Larsen <blarsen@redhat.com>,
gdb-patches@sourceware.org,
UlrichWeigand <Ulrich.Weigand@de.ibm.com>,
pedro@palves.net
Cc: cel@us.ibm.com
Subject: RE: [PATCH v3] Fix reverse stepping multiple contiguous PC ranges over the line table.
Date: Fri, 05 May 2023 09:10:30 -0700 [thread overview]
Message-ID: <f9a6467d7294b2e892b2290e1b1144e35747ed40.camel@us.ibm.com> (raw)
In-Reply-To: <23c8e441-f6bc-37b2-8101-e9a4030c7c8b@arm.com>
Luis:
On Fri, 2023-05-05 at 15:59 +0100, Luis Machado wrote:
> > + /* Call find_line_range_start to get smallest address in the
>
> s/smallest/the smallest
>
> > + linetable for multiple Line X entries in the line table. */
> > + real_range_start = find_line_range_start (pc);
> > +
> > + if (real_range_start.has_value ())
<snip>
> Other than the nit, this LGTM. Thanks for picking this one up and
> improving it to fix other issues.
>
> Reviewed-by: Luis Machado <luis.machado@arm.com>
Thanks for the review. I updated the patch with the fix. Probably not
worth resending patch but will make sure it does get included in any
future posts or commits.
Carl
next prev parent reply other threads:[~2023-05-05 16:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 20:59 [PATCH] " Carl Love
2023-05-02 14:15 ` Bruno Larsen
2023-05-02 15:40 ` Carl Love
2023-05-02 15:42 ` Bruno Larsen
2023-05-11 15:11 ` Simon Marchi
2023-05-03 9:53 ` Bruno Larsen
2023-05-04 2:55 ` Carl Love
2023-05-04 9:24 ` Bruno Larsen
2023-05-04 14:52 ` Carl Love
2023-05-04 2:55 ` [PATCH v2] " Carl Love
2023-05-04 15:59 ` [PATCH v3] " Carl Love
2023-05-05 14:59 ` Luis Machado
2023-05-05 16:10 ` Carl Love [this message]
2023-05-10 13:47 ` Bruno Larsen
2023-05-10 17:16 ` Carl Love
2023-05-10 17:32 ` [PATCH v4] " Carl Love
2023-05-11 16:01 ` Simon Marchi
2023-05-11 16:23 ` Bruno Larsen
2023-05-11 17:28 ` Simon Marchi
2023-05-16 22:54 ` [PATCH 1/2] " Carl Love
2023-06-19 17:11 ` Simon Marchi
2023-06-22 16:52 ` Carl Love
2023-06-23 17:44 ` Simon Marchi
2023-06-23 19:41 ` Carl Love
2023-06-23 20:04 ` [PATCH 1/2 ver 2] " Carl Love
2023-07-06 15:07 ` Carl Love
2023-05-16 22:54 ` [PATCH 2/2 v5] " Carl Love
2023-05-25 15:08 ` Carl Love
2023-06-08 16:36 ` Carl Love
2023-06-19 17:58 ` Simon Marchi
2023-06-22 20:38 ` Carl Love
2023-06-22 20:39 ` Carl Love
2023-06-23 17:49 ` Simon Marchi
2023-06-23 20:04 ` Carl Love
2023-06-23 20:04 ` [PATCH 2/2 v6] " Carl Love
2023-05-16 22:54 ` [PATCH v4] " Carl Love
2023-05-11 7:52 ` [PATCH v3] " Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a6467d7294b2e892b2290e1b1144e35747ed40.camel@us.ibm.com \
--to=cel@us.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).