public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Kevin Buettner <kevinb@redhat.com>,
	Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] [gdb/symtab] Don't deduplicate variables in gdb-index
Date: Sun, 13 Aug 2023 23:29:14 +0200	[thread overview]
Message-ID: <f9da36c7-ce0c-c508-9e13-60f703b99e07@suse.de> (raw)
In-Reply-To: <20230812211119.20413b22@f37-zws-nv>

On 8/13/23 06:11, Kevin Buettner wrote:
> On Fri,  4 Aug 2023 19:35:42 +0200
> Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> wrote:
> 
>> Fix this in symtab_index_entry::minimize, by not deduplicating variables.
>>
>> Tested on x86_64-linux, with target boards unix and cc-with-gdb-index.
> 
> LGTM.
> 

Hi Kevin,

thanks for the review, I've pushed this after fixing a typo in the log 
message and a nit the updated comment.

Thanks,
- Tom

> Reviewed-by: Kevin Buettner <kevinb@redhat.com>
> 


      reply	other threads:[~2023-08-13 21:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 17:35 Tom de Vries
2023-08-13  4:11 ` Kevin Buettner
2023-08-13 21:29   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9da36c7-ce0c-c508-9e13-60f703b99e07@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).