From: Bruno Larsen <blarsen@redhat.com>
To: gdb-patches@sourceware.org
Cc: gdb@sourceware.org
Subject: [PING][PATCH 0/1] update MAINTAINERS file with git trailers
Date: Tue, 30 May 2023 11:02:54 +0200 [thread overview]
Message-ID: <fba7580d-a971-40bd-3901-d3909eccb0fa@redhat.com> (raw)
In-Reply-To: <20230516143826.3431583-1-blarsen@redhat.com>
ping! :)
There has been some chat about this, but I'd like some more maintainers
chiming in to ensure that everyone is following the same process.
Sending an ack/LGTM if everything seems obvious is much appreciated :)
--
Cheers,
Bruno
On 16/05/2023 16:38, Bruno Larsen wrote:
> Some private chats highlighted that the currently in use git trailers
> aren't explained well enough. This patch aims to fix that by adding the
> information in a more verbose way to guarantee that everyone is on the
> same page about them and refine anything that might still need work.
>
> There was also an update to the contribution checklist[1], which was the
> only way the trailers were officially documented. I'm not sure if that
> addition was properly reviewed, so more eyes are welcome, especially
> after this change goes through.
>
> Finally, I also have some suggested git commands to help with managing
> the git trailers that I'd like to add to a relevant place, where would I
> add it? For those curious, it's a git alias[2] to add a trailer to the
> most recent commit.
>
> [1] https://sourceware.org/gdb/wiki/ContributionChecklist#Receiving_positive_reviews
> [2] gdb-trailer = commit --amend --no-edit --trailer
>
> Bruno Larsen (1):
> [gdb]: add git trailer information on gdb/MAINTAINERS
>
> gdb/MAINTAINERS | 48 +++++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 39 insertions(+), 9 deletions(-)
>
prev parent reply other threads:[~2023-05-30 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 14:38 [PATCH " Bruno Larsen
2023-05-16 14:38 ` [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Bruno Larsen
2023-05-16 16:04 ` Eli Zaretskii
2023-05-16 16:41 ` Bruno Larsen
2023-05-16 17:48 ` Eli Zaretskii
2023-05-16 19:40 ` Simon Marchi
2023-05-17 2:28 ` Eli Zaretskii
2023-05-17 8:19 ` Bruno Larsen
2023-05-17 14:35 ` Simon Marchi
2023-05-30 9:02 ` Bruno Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba7580d-a971-40bd-3901-d3909eccb0fa@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).