From: Simon Marchi <simark@simark.ca>
To: Bruno Larsen <blarsen@redhat.com>, Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, gdb@sourceware.org
Subject: Re: [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS
Date: Wed, 17 May 2023 10:35:00 -0400 [thread overview]
Message-ID: <64b12aa0-89e4-c6e7-aeb2-a7f7e2b1aa96@simark.ca> (raw)
In-Reply-To: <71a08d05-ce55-ec44-2804-13145283ef6b@redhat.com>
> My reading of the kernel's documentation of the tag[1] makes it sound like it is a partial approval, especially the lines:
>
> |
>
> Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
> has at least reviewed the patch and has indicated acceptance.|
>
> And the only time I saw it used in QEMU seems to corroborate that reading. That said, I can be misunderstanding here (english is not my native language after all).
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=HEAD#n441
Thanks for the pointers. It looks like Acked-By can fit a range of
situations, as long as it fits in "I didn't look at all of it or didn't
do a thoroug review, but what I have seen LGTM". I think it fits my use
case of just reading the commit message and agreeing with that.
Simon
next prev parent reply other threads:[~2023-05-17 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 14:38 [PATCH 0/1] update MAINTAINERS file with git trailers Bruno Larsen
2023-05-16 14:38 ` [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Bruno Larsen
2023-05-16 16:04 ` Eli Zaretskii
2023-05-16 16:41 ` Bruno Larsen
2023-05-16 17:48 ` Eli Zaretskii
2023-05-16 19:40 ` Simon Marchi
2023-05-17 2:28 ` Eli Zaretskii
2023-05-17 8:19 ` Bruno Larsen
2023-05-17 14:35 ` Simon Marchi [this message]
2023-05-30 9:02 ` [PING][PATCH 0/1] update MAINTAINERS file with git trailers Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b12aa0-89e4-c6e7-aeb2-a7f7e2b1aa96@simark.ca \
--to=simark@simark.ca \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).