From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 4/4] gdb/Makefile: Print 'GEN' message, and pass SILENT_FLAG more
Date: Fri, 5 Apr 2024 13:21:28 +0100 [thread overview]
Message-ID: <fcbf5f50a0ede2171672deaeccaa32546c6b246c.1712319537.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1712319537.git.aburgess@redhat.com>
The targets that use config.status to regenerate themselves don't
currently follow the silent rules that the rest of GDB's Makefile
does. For example, touch the gdb/gcore.in file and then 'make all' in
the gdb/ directory prints:
/bin/sh config.status gcore
config.status: creating gcore
In this commit I make use of the silent-rules.mk mechanism for these
targets, now we get:
GEN gcore
Which matches the rest of our Makefile. Obviously, if you pass 'V=1'
to the build then you'll get the old output back.
There's no change in what is generated after this commit.
---
gdb/Makefile.in | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index c1b3144b175..e9a6247c38d 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2307,31 +2307,31 @@ subdir_do: force
done
Makefile: Makefile.in config.status
- $(SHELL) config.status $@
+ $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@
.PHONY: run
run: Makefile
./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS)
jit-reader.h: $(srcdir)/jit-reader.in config.status
- $(SHELL) config.status $@
+ $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@
gcore: $(srcdir)/gcore.in config.status
- $(SHELL) config.status $@
+ $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@
gdb-gdb.py: $(srcdir)/gdb-gdb.py.in config.status
- $(SHELL) config.status $@
+ $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@
gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in config.status
- $(SHELL) config.status $@
+ $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@
config.h: stamp-h ; @true
stamp-h: $(srcdir)/config.in config.status
- $(SHELL) config.status config.h
+ $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) config.h
nm.h: stamp-nmh ; @true
stamp-nmh: config.status
- $(SHELL) config.status nm.h
+ $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) nm.h
# Files included from config.status or the configure script. When
# these change the configure script doesn't need regenerating, but its
@@ -2345,7 +2345,7 @@ config_status_deps = \
$(srcdir)/../bfd/config.bfd
config.status: $(config_status_deps)
- $(SHELL) config.status --recheck
+ $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) --recheck
ACLOCAL = aclocal
--
2.25.4
next prev parent reply other threads:[~2024-04-05 12:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 12:21 [PATCH 0/4] gcore and config.status related Makefile changes Andrew Burgess
2024-04-05 12:21 ` [PATCH 1/4] gdb/Makefile: add gcore to the 'all' target dependency list Andrew Burgess
2024-04-05 12:21 ` [PATCH 2/4] gdb/Makefile: rewrite dependencies for config.status target Andrew Burgess
2024-04-05 12:21 ` [PATCH 3/4] gdb/Makefile: add some missing config.status dependencies Andrew Burgess
2024-04-05 12:21 ` Andrew Burgess [this message]
2024-04-06 17:03 ` [PATCHv2 0/6] gcore and config.status related Makefile changes Andrew Burgess
2024-04-06 17:03 ` [PATCHv2 1/6] gdb/Makefile: add gcore to the 'all' target dependency list Andrew Burgess
2024-04-06 17:03 ` [PATCHv2 2/6] gdb/Makefile: rewrite dependencies for config.status target Andrew Burgess
2024-04-08 3:09 ` Simon Marchi
2024-04-06 17:03 ` [PATCHv2 3/6] gdb/Makefile: add some missing config.status dependencies Andrew Burgess
2024-04-06 17:03 ` [PATCHv2 4/6] gdb/Makefile: Print 'GEN' message, and pass SILENT_FLAG more Andrew Burgess
2024-04-06 17:03 ` [PATCHv2 5/6] gdb/configure: use AC_MSG_NOTICE not a direct echo call Andrew Burgess
2024-04-08 3:14 ` Simon Marchi
2024-04-08 10:01 ` Andrew Burgess
2024-04-09 15:53 ` Tom Tromey
2024-04-06 17:03 ` [PATCHv2 6/6] gdb/build: apply silent-rules.mk to the data-directory Makefile.in Andrew Burgess
2024-04-08 3:32 ` Simon Marchi
2024-04-08 9:16 ` Andrew Burgess
2024-04-08 3:32 ` [PATCHv2 0/6] gcore and config.status related Makefile changes Simon Marchi
2024-04-08 10:01 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcbf5f50a0ede2171672deaeccaa32546c6b246c.1712319537.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).