public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 3/4] gdb/Makefile: add some missing config.status dependencies
Date: Fri,  5 Apr 2024 13:21:27 +0100	[thread overview]
Message-ID: <7c64e75ac82b176db8bd4572ace865076851c36e.1712319537.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1712319537.git.aburgess@redhat.com>

I noticed that for the build targets jit-reader.h, gcore, gdb-gdb.py,
and gdb-gdb.gdb the rules all use the config.status script, but don't
have a dependency on the config.status target.  This means we might
fail to regenerate these targets in a case where config.status, or one
of its dependencies changes.

Two other targets that use config.status do correctly have a
dependency on config.status.

Fixed in this commit by adding the missing dependencies.

There should be no changes in _what_ is generated after this commit.
---
 gdb/Makefile.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 9340becbdc9..c1b3144b175 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2313,16 +2313,16 @@ Makefile: Makefile.in config.status
 run: Makefile
 	./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS)
 
-jit-reader.h: $(srcdir)/jit-reader.in
+jit-reader.h: $(srcdir)/jit-reader.in config.status
 	$(SHELL) config.status $@
 
-gcore: $(srcdir)/gcore.in
+gcore: $(srcdir)/gcore.in config.status
 	$(SHELL) config.status $@
 
-gdb-gdb.py: $(srcdir)/gdb-gdb.py.in
+gdb-gdb.py: $(srcdir)/gdb-gdb.py.in config.status
 	$(SHELL) config.status $@
 
-gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in
+gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in config.status
 	$(SHELL) config.status $@
 
 config.h: stamp-h ; @true
-- 
2.25.4


  parent reply	other threads:[~2024-04-05 12:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 12:21 [PATCH 0/4] gcore and config.status related Makefile changes Andrew Burgess
2024-04-05 12:21 ` [PATCH 1/4] gdb/Makefile: add gcore to the 'all' target dependency list Andrew Burgess
2024-04-05 12:21 ` [PATCH 2/4] gdb/Makefile: rewrite dependencies for config.status target Andrew Burgess
2024-04-05 12:21 ` Andrew Burgess [this message]
2024-04-05 12:21 ` [PATCH 4/4] gdb/Makefile: Print 'GEN' message, and pass SILENT_FLAG more Andrew Burgess
2024-04-06 17:03 ` [PATCHv2 0/6] gcore and config.status related Makefile changes Andrew Burgess
2024-04-06 17:03   ` [PATCHv2 1/6] gdb/Makefile: add gcore to the 'all' target dependency list Andrew Burgess
2024-04-06 17:03   ` [PATCHv2 2/6] gdb/Makefile: rewrite dependencies for config.status target Andrew Burgess
2024-04-08  3:09     ` Simon Marchi
2024-04-06 17:03   ` [PATCHv2 3/6] gdb/Makefile: add some missing config.status dependencies Andrew Burgess
2024-04-06 17:03   ` [PATCHv2 4/6] gdb/Makefile: Print 'GEN' message, and pass SILENT_FLAG more Andrew Burgess
2024-04-06 17:03   ` [PATCHv2 5/6] gdb/configure: use AC_MSG_NOTICE not a direct echo call Andrew Burgess
2024-04-08  3:14     ` Simon Marchi
2024-04-08 10:01       ` Andrew Burgess
2024-04-09 15:53     ` Tom Tromey
2024-04-06 17:03   ` [PATCHv2 6/6] gdb/build: apply silent-rules.mk to the data-directory Makefile.in Andrew Burgess
2024-04-08  3:32     ` Simon Marchi
2024-04-08  9:16       ` Andrew Burgess
2024-04-08  3:32   ` [PATCHv2 0/6] gcore and config.status related Makefile changes Simon Marchi
2024-04-08 10:01     ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c64e75ac82b176db8bd4572ace865076851c36e.1712319537.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).