From: Bruno Larsen <blarsen@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/6] Use bool in value
Date: Wed, 15 Feb 2023 13:22:19 +0100 [thread overview]
Message-ID: <fd6890ce-5819-1b31-5088-4fe01fd3e37b@redhat.com> (raw)
In-Reply-To: <20230214-submit-more-value-stuff-v1-0-2fb85efbaa72@tromey.com>
On 14/02/2023 21:23, Tom Tromey wrote:
> There are a few spots in struct value that should use 'bool'. This
> short series fixes these up.
>
> Regression tested on x86-64 Fedora 36.
>
> ---
> Tom Tromey (6):
> Change value::m_modifiable to bool
> Change value::m_lazy to bool
> Change value::m_initialized to bool
> Change value::m_stack to bool
> Have value::bits_synthetic_pointer return bool
> Return bool from more value methods
>
> gdb/breakpoint.c | 3 +--
> gdb/dwarf2/expr.c | 12 ++++-----
> gdb/dwarf2/expr.h | 6 ++---
> gdb/dwarf2/loc.c | 2 +-
> gdb/frame-unwind.c | 2 +-
> gdb/gnu-v2-abi.c | 2 +-
> gdb/opencl-lang.c | 10 ++++----
> gdb/ppc-linux-nat.c | 2 +-
> gdb/valops.c | 4 +--
> gdb/valprint.c | 2 +-
> gdb/value.c | 48 +++++++++++++++++------------------
> gdb/value.h | 72 ++++++++++++++++++++++++++---------------------------
> 12 files changed, 82 insertions(+), 83 deletions(-)
> ---
> base-commit: 5bed9dc992a0136d403a7addb29a2ed822fd4fd2
> change-id: 20230214-submit-more-value-stuff-dea23b091773
>
> Best regards,
I've double checked the testing and changes, and apart from a comment on
patch #2 everything looks ready to go. You may apply my tag to the whole
series:
Reviewed-By: Bruno Larsen <blarsen@redhat.com>
--
Cheers,
Bruno
next prev parent reply other threads:[~2023-02-15 12:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 20:23 Tom Tromey
2023-02-14 20:23 ` [PATCH 1/6] Change value::m_modifiable to bool Tom Tromey
2023-02-21 14:36 ` Alexandra Petlanova Hajkova
2023-02-14 20:23 ` [PATCH 2/6] Change value::m_lazy " Tom Tromey
2023-02-15 11:53 ` Bruno Larsen
2023-02-15 21:52 ` Tom Tromey
2023-02-14 20:23 ` [PATCH 3/6] Change value::m_initialized " Tom Tromey
2023-02-21 15:10 ` Alexandra Petlanova Hajkova
2023-02-14 20:23 ` [PATCH 4/6] Change value::m_stack " Tom Tromey
2023-02-21 15:30 ` Alexandra Petlanova Hajkova
2023-02-14 20:23 ` [PATCH 5/6] Have value::bits_synthetic_pointer return bool Tom Tromey
2023-02-14 20:23 ` [PATCH 6/6] Return bool from more value methods Tom Tromey
2023-02-15 12:22 ` Bruno Larsen [this message]
2023-02-15 21:54 ` [PATCH 0/6] Use bool in value Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd6890ce-5819-1b31-5088-4fe01fd3e37b@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).