* [review] Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp
@ 2019-11-09 20:59 Kevin Buettner (Code Review)
2019-12-03 16:42 ` Pedro Alves (Code Review)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kevin Buettner (Code Review) @ 2019-11-09 20:59 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/604
......................................................................
Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp
This commit adds the gdb_caching_proc, support_nested_function_tests,
to lib/gdb.exp. It tests to see whether or not the C compiler has
support for nested function calls.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (support_nested_function_tests): New proc.
Change-Id: Ic2c93bc4cc200e07e104a2398f89a9c0514bdc75
---
M gdb/testsuite/lib/gdb.exp
1 file changed, 15 insertions(+), 0 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 1731a3e..31205c8 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -6385,6 +6385,21 @@
return $supports_schedule_locking
}
+# Return 1 if compiler supports use of nested functions. Otherwise,
+# return 0.
+
+gdb_caching_proc support_nested_function_tests {
+ # Compile a test program containing a nested function
+ return [gdb_can_simple_compile nested_func {
+ int main () {
+ int foo () {
+ return 0;
+ }
+ return foo ();
+ }
+ } executable]
+}
+
# gdb_target_symbol returns the provided symbol with the correct prefix
# prepended. (See gdb_target_symbol_prefix, above.)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic2c93bc4cc200e07e104a2398f89a9c0514bdc75
Gerrit-Change-Number: 604
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Buettner <kevinb@redhat.com>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 4+ messages in thread
* [review] Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp
2019-11-09 20:59 [review] Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp Kevin Buettner (Code Review)
@ 2019-12-03 16:42 ` Pedro Alves (Code Review)
2019-12-10 22:46 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-10 22:46 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Pedro Alves (Code Review) @ 2019-12-03 16:42 UTC (permalink / raw)
To: Kevin Buettner, gdb-patches
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/604
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
| --- gdb/testsuite/lib/gdb.exp
| +++ gdb/testsuite/lib/gdb.exp
| @@ -6383,5 +6383,19 @@ gdb_caching_proc target_supports_scheduler_locking {
| remote_file build delete $obj
| verbose "$me: returning $supports_schedule_locking" 2
| return $supports_schedule_locking
| }
|
| +# Return 1 if compiler supports use of nested functions. Otherwise,
| +# return 0.
| +
| +gdb_caching_proc support_nested_function_tests {
| + # Compile a test program containing a nested function
PS1, Line 6392:
Missing end period.
| + return [gdb_can_simple_compile nested_func {
| + int main () {
| + int foo () {
| + return 0;
| + }
| + return foo ();
| + }
| + } executable]
| +}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic2c93bc4cc200e07e104a2398f89a9c0514bdc75
Gerrit-Change-Number: 604
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Buettner <kevinb@redhat.com>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 16:41:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp
2019-11-09 20:59 [review] Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp Kevin Buettner (Code Review)
2019-12-03 16:42 ` Pedro Alves (Code Review)
@ 2019-12-10 22:46 ` Sourceware to Gerrit sync (Code Review)
2019-12-10 22:46 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-10 22:46 UTC (permalink / raw)
To: Kevin Buettner, Pedro Alves, gdb-patches
The original change was created by Kevin Buettner.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/604
......................................................................
Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp
This commit adds the gdb_caching_proc, support_nested_function_tests,
to lib/gdb.exp. It tests to see whether or not the C compiler has
support for nested function calls.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (support_nested_function_tests): New proc.
Change-Id: Ic2c93bc4cc200e07e104a2398f89a9c0514bdc75
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/lib/gdb.exp
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index d3510d4..4b2e132 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,8 +1,12 @@
2019-12-10 Kevin Buettner <kevinb@redhat.com>
- * lib/gdb.exp (gdb_compile_openmp): New proc.
- (build_executable_from_specs): Add an "openmp" option.
- (gdb_compile_pthreads): Add non-executable case.
+ * lib/gdb.exp (support_nested_function_tests): New proc.
+
+2019-12-10 Kevin Buettner <kevinb@redhat.com>
+
+ * lib/gdb.exp (gdb_compile_openmp): New proc.
+ (build_executable_from_specs): Add an "openmp" option.
+ (gdb_compile_pthreads): Add non-executable case.
2019-12-10 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 806e5a0..8b1ec62 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -6395,6 +6395,21 @@
return $supports_schedule_locking
}
+# Return 1 if compiler supports use of nested functions. Otherwise,
+# return 0.
+
+gdb_caching_proc support_nested_function_tests {
+ # Compile a test program containing a nested function
+ return [gdb_can_simple_compile nested_func {
+ int main () {
+ int foo () {
+ return 0;
+ }
+ return foo ();
+ }
+ } executable]
+}
+
# gdb_target_symbol returns the provided symbol with the correct prefix
# prepended. (See gdb_target_symbol_prefix, above.)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic2c93bc4cc200e07e104a2398f89a9c0514bdc75
Gerrit-Change-Number: 604
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Buettner <kevinb@redhat.com>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp
2019-11-09 20:59 [review] Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp Kevin Buettner (Code Review)
2019-12-03 16:42 ` Pedro Alves (Code Review)
2019-12-10 22:46 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-10 22:46 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-10 22:46 UTC (permalink / raw)
To: Kevin Buettner, gdb-patches; +Cc: Pedro Alves
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/604
......................................................................
Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp
This commit adds the gdb_caching_proc, support_nested_function_tests,
to lib/gdb.exp. It tests to see whether or not the C compiler has
support for nested function calls.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (support_nested_function_tests): New proc.
Change-Id: Ic2c93bc4cc200e07e104a2398f89a9c0514bdc75
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/lib/gdb.exp
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index d3510d4..4b2e132 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,8 +1,12 @@
2019-12-10 Kevin Buettner <kevinb@redhat.com>
- * lib/gdb.exp (gdb_compile_openmp): New proc.
- (build_executable_from_specs): Add an "openmp" option.
- (gdb_compile_pthreads): Add non-executable case.
+ * lib/gdb.exp (support_nested_function_tests): New proc.
+
+2019-12-10 Kevin Buettner <kevinb@redhat.com>
+
+ * lib/gdb.exp (gdb_compile_openmp): New proc.
+ (build_executable_from_specs): Add an "openmp" option.
+ (gdb_compile_pthreads): Add non-executable case.
2019-12-10 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 806e5a0..8b1ec62 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -6395,6 +6395,21 @@
return $supports_schedule_locking
}
+# Return 1 if compiler supports use of nested functions. Otherwise,
+# return 0.
+
+gdb_caching_proc support_nested_function_tests {
+ # Compile a test program containing a nested function
+ return [gdb_can_simple_compile nested_func {
+ int main () {
+ int foo () {
+ return 0;
+ }
+ return foo ();
+ }
+ } executable]
+}
+
# gdb_target_symbol returns the provided symbol with the correct prefix
# prepended. (See gdb_target_symbol_prefix, above.)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic2c93bc4cc200e07e104a2398f89a9c0514bdc75
Gerrit-Change-Number: 604
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Buettner <kevinb@redhat.com>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-10 22:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09 20:59 [review] Add gdb_caching_proc support_nested_function_tests to lib/gdb.exp Kevin Buettner (Code Review)
2019-12-03 16:42 ` Pedro Alves (Code Review)
2019-12-10 22:46 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-10 22:46 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).