* [review] Minor fix to gdb.prompt documentation
@ 2019-11-20 23:09 Tom Tromey (Code Review)
2019-12-04 22:23 ` Tom Tromey
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-20 23:09 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
......................................................................
Minor fix to gdb.prompt documentation
I noticed that an example in the gdb.prompt documentation used the
wrong kind of quotes -- because it is code, it should use a plain
ASCII quotation mark. I also slightly shortened the sample text here,
so it would more clearly fit on a single line.
gdb/doc/ChangeLog
2019-11-20 Tom Tromey <tom@tromey.com>
* python.texi (gdb.prompt): Use correct quotes in example.
Shorten sample text.
Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
---
M gdb/doc/ChangeLog
M gdb/doc/python.texi
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 2571839..c7eb50c 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-20 Tom Tromey <tom@tromey.com>
+
+ * python.texi (gdb.prompt): Use correct quotes in example.
+ Shorten sample text.
+
2019-11-14 Tom de Vries <tdevries@suse.de>
* gdb.texinfo: Fix typos.
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index ed73bbf..f807fb2 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -5937,13 +5937,12 @@
For example:
@smallexample
-substitute_prompt (``frame: \f,
- print arguments: \p@{print frame-arguments@}'')
+substitute_prompt ("frame: \f, args: \p@{print frame-arguments@}")
@end smallexample
@exdent will return the string:
@smallexample
-"frame: main, print arguments: scalars"
+"frame: main, args: scalars"
@end smallexample
@end table
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
Gerrit-Change-Number: 693
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review] Minor fix to gdb.prompt documentation
2019-11-20 23:09 [review] Minor fix to gdb.prompt documentation Tom Tromey (Code Review)
@ 2019-12-04 22:23 ` Tom Tromey
2019-12-06 18:54 ` Pedro Alves (Code Review)
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Tom Tromey @ 2019-12-04 22:23 UTC (permalink / raw)
To: gdb-patches
>>>>> "Tom" == Tom Tromey (Code Review) <gerrit@gnutoolchain-gerrit.osci.io> writes:
Tom> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
Tom> ......................................................................
Tom> Minor fix to gdb.prompt documentation
...
Tom> gdb/doc/ChangeLog
Tom> 2019-11-20 Tom Tromey <tom@tromey.com>
Tom> * python.texi (gdb.prompt): Use correct quotes in example.
Tom> Shorten sample text.
Ping.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* [review] Minor fix to gdb.prompt documentation
2019-11-20 23:09 [review] Minor fix to gdb.prompt documentation Tom Tromey (Code Review)
2019-12-04 22:23 ` Tom Tromey
2019-12-06 18:54 ` Pedro Alves (Code Review)
@ 2019-12-06 18:54 ` Pedro Alves (Code Review)
2019-12-10 22:58 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-10 22:58 ` Sourceware to Gerrit sync (Code Review)
4 siblings, 0 replies; 6+ messages in thread
From: Pedro Alves (Code Review) @ 2019-12-06 18:54 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
......................................................................
Patch Set 1: Code-Review+2
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
Gerrit-Change-Number: 693
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 18:54:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 6+ messages in thread
* [review] Minor fix to gdb.prompt documentation
2019-11-20 23:09 [review] Minor fix to gdb.prompt documentation Tom Tromey (Code Review)
2019-12-04 22:23 ` Tom Tromey
@ 2019-12-06 18:54 ` Pedro Alves (Code Review)
2019-12-06 18:54 ` Pedro Alves (Code Review)
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Pedro Alves (Code Review) @ 2019-12-06 18:54 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
......................................................................
Patch Set 1:
(I think this can go in as obvious.)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
Gerrit-Change-Number: 693
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 18:54:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 6+ messages in thread
* [pushed] Minor fix to gdb.prompt documentation
2019-11-20 23:09 [review] Minor fix to gdb.prompt documentation Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-12-06 18:54 ` Pedro Alves (Code Review)
@ 2019-12-10 22:58 ` Sourceware to Gerrit sync (Code Review)
2019-12-10 22:58 ` Sourceware to Gerrit sync (Code Review)
4 siblings, 0 replies; 6+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-10 22:58 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Pedro Alves
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
......................................................................
Minor fix to gdb.prompt documentation
I noticed that an example in the gdb.prompt documentation used the
wrong kind of quotes -- because it is code, it should use a plain
ASCII quotation mark. I also slightly shortened the sample text here,
so it would more clearly fit on a single line.
gdb/doc/ChangeLog
2019-12-10 Tom Tromey <tom@tromey.com>
* python.texi (gdb.prompt): Use correct quotes in example.
Shorten sample text.
Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
---
M gdb/doc/ChangeLog
M gdb/doc/python.texi
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 9a70de3..57ad682 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-10 Tom Tromey <tom@tromey.com>
+
+ * python.texi (gdb.prompt): Use correct quotes in example.
+ Shorten sample text.
+
2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
* doc/gdb.texinfo (GDB/MI Symbol Query): Add documentation of
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index ed73bbf..f807fb2 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -5937,13 +5937,12 @@
For example:
@smallexample
-substitute_prompt (``frame: \f,
- print arguments: \p@{print frame-arguments@}'')
+substitute_prompt ("frame: \f, args: \p@{print frame-arguments@}")
@end smallexample
@exdent will return the string:
@smallexample
-"frame: main, print arguments: scalars"
+"frame: main, args: scalars"
@end smallexample
@end table
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
Gerrit-Change-Number: 693
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 6+ messages in thread
* [pushed] Minor fix to gdb.prompt documentation
2019-11-20 23:09 [review] Minor fix to gdb.prompt documentation Tom Tromey (Code Review)
` (3 preceding siblings ...)
2019-12-10 22:58 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-10 22:58 ` Sourceware to Gerrit sync (Code Review)
4 siblings, 0 replies; 6+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-10 22:58 UTC (permalink / raw)
To: Tom Tromey, Pedro Alves, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/693
......................................................................
Minor fix to gdb.prompt documentation
I noticed that an example in the gdb.prompt documentation used the
wrong kind of quotes -- because it is code, it should use a plain
ASCII quotation mark. I also slightly shortened the sample text here,
so it would more clearly fit on a single line.
gdb/doc/ChangeLog
2019-12-10 Tom Tromey <tom@tromey.com>
* python.texi (gdb.prompt): Use correct quotes in example.
Shorten sample text.
Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
---
M gdb/doc/ChangeLog
M gdb/doc/python.texi
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 9a70de3..57ad682 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-10 Tom Tromey <tom@tromey.com>
+
+ * python.texi (gdb.prompt): Use correct quotes in example.
+ Shorten sample text.
+
2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
* doc/gdb.texinfo (GDB/MI Symbol Query): Add documentation of
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index ed73bbf..f807fb2 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -5937,13 +5937,12 @@
For example:
@smallexample
-substitute_prompt (``frame: \f,
- print arguments: \p@{print frame-arguments@}'')
+substitute_prompt ("frame: \f, args: \p@{print frame-arguments@}")
@end smallexample
@exdent will return the string:
@smallexample
-"frame: main, print arguments: scalars"
+"frame: main, args: scalars"
@end smallexample
@end table
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4153928c0d88001244ad410f3943c952a6ebfeb1
Gerrit-Change-Number: 693
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-10 22:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-20 23:09 [review] Minor fix to gdb.prompt documentation Tom Tromey (Code Review)
2019-12-04 22:23 ` Tom Tromey
2019-12-06 18:54 ` Pedro Alves (Code Review)
2019-12-06 18:54 ` Pedro Alves (Code Review)
2019-12-10 22:58 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-10 22:58 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).