Re: remote/2550: st_dev field not set for remote 'fstat' of file

Re: remote/2550: st_dev field not set for remote 'fstat' of file

[Richard Stuckey]

The following reply was made to PR remote/2550; it has been noted by GNATS.

From: Richard Stuckey <richard.stuckey@arc.com>
To: gdb-gnats@sources.redhat.com
Cc:  
Subject: Re: remote/2550: st_dev field not set for remote 'fstat' of file
Date: Mon, 10 Nov 2008 16:11:05 +0000

 The function names 'target_*' in the description should have been
 'remote_*'.

remote/2550: st_dev field not set for remote 'fstat' of file

[richard.stuckey]

>Number:         2550
>Category:       remote
>Synopsis:       st_dev field not set for remote 'fstat' of file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 10 16:08:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     ARC International
>Release:        6.8
>Organization:
>Environment:

>Description:
The function target_fileio_to_fio_stat in file remote-fileio.c does not set the 'st_dev' field of the 'struct fio_stat' that it is constructing; there is a comment in the code that this is done by the calling function.

However, in the function remote_fileio_func_fstat (one of its callers), this is only done for the console_in/out files - the field is left undefined for other files.

The fix is to add the line

    target_fileio_to_fio_uint (st.st_dev, fst.fst_dev);

to the 'else' part a few lines before the call to target_fileio_to_fio_stat, immediately after the call to fstat.
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: