Re: cli/2563: redefining command causes hooks to be lost

Re: cli/2563: redefining command causes hooks to be lost

[tromey]

Synopsis: redefining command causes hooks to be lost

Responsible-Changed-From-To: unassigned->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Wed Dec 10 22:29:12 2008
Responsible-Changed-Why:
    I'm testing a patch.

http://sourceware.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=2563

Re: cli/2563: redefining command causes hooks to be lost

[tromey]

Synopsis: redefining command causes hooks to be lost

State-Changed-From-To: open->closed
State-Changed-By: tromey
State-Changed-When: Fri Dec 12 18:00:55 2008
State-Changed-Why:
    Fix checked in.

http://sourceware.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=2563

cli/2563: redefining command causes hooks to be lost

[brobecker]

>Number:         2563
>Category:       cli
>Synopsis:       redefining command causes hooks to be lost
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 09 10:48:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Joel Brobecker
>Release:        6.8 (reproduced with 6.8.50.20081205-cvs)
>Organization:
>Environment:

>Description:
When redefining a command that has a hook attached to it, the new command is missing the hook.  For instance, consider the following:

(gdb) define cmd
Type commands for definition of "cmd".
End with a line saying just "end".
> echo cmd\n
> end
(gdb) define hook-cmd
Type commands for definition of "hook-cmd".
End with a line saying just "end".
> echo hook-cmd\n
> end

Calling our new "cmd" causes "hook-cmd" to be called as well:

(gdb) cmd
hook-cmd
cmd

Now, if we redefine "cmd":

(gdb) define cmd
Redefine command "cmd"? (y or n) y
Type commands for definition of "cmd".
End with a line saying just "end".
> echo cmd2\n
> end

Then calling "cmd" again shows that "hook-cmd" is no longer called:

(gdb) cmd
cmd2

>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: