public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug remote/8800] Incorrect error message
       [not found] <20040626201801.8800.jon@beniston.com>
@ 2008-12-23 18:17 ` pedro at codesourcery dot com
  2008-12-23 18:34 ` pedro at codesourcery dot com
  1 sibling, 0 replies; 2+ messages in thread
From: pedro at codesourcery dot com @ 2008-12-23 18:17 UTC (permalink / raw)
  To: gdb-prs


------- Additional Comments From pedro at codesourcery dot com  2008-12-23 18:17 -------
"hex digit" here is refering to the fact that xx is supposed to be a character
representing an hexadecimal digit.  If we used %x here as suggested, and, e.g.,
the bad character was a 'g', you'd get a still unclear error message like:

"Reply contains invalid hex digit 67"

or:

"Reply contains invalid hex digit 0x67"

Most of the other places we error out claiming the packet is malformed, we print
the buffer as a string.  I'd suggest instead to make the error message a bit
clearer, say, by trying to show the bad character:

    error (_("Reply contains invalid hex digit %d ('%c')"), a, a);

"Reply contains invalid hex digit 103 ('g')"

I'm sure there's even a better wording for this.  Suggestions?


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=8800

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 2+ messages in thread
* [Bug remote/8800] Incorrect error message
       [not found] <20040626201801.8800.jon@beniston.com>
  2008-12-23 18:17 ` [Bug remote/8800] Incorrect error message pedro at codesourcery dot com
@ 2008-12-23 18:34 ` pedro at codesourcery dot com
  1 sibling, 0 replies; 2+ messages in thread
From: pedro at codesourcery dot com @ 2008-12-23 18:34 UTC (permalink / raw)
  To: gdb-prs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement


http://sourceware.org/bugzilla/show_bug.cgi?id=8800

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-23 18:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20040626201801.8800.jon@beniston.com>
2008-12-23 18:17 ` [Bug remote/8800] Incorrect error message pedro at codesourcery dot com
2008-12-23 18:34 ` pedro at codesourcery dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).