[Bug tdep/9745] New: mips32_next_pc doesn't handle JALX

[Bug tdep/9745] New: mips32_next_pc doesn't handle JALX

[bugs at ebshome dot net]

Handling of JALX is currently missing from mips32_next_pc (code is there but
it's not used - FIXME comment).

-- 
           Summary: mips32_next_pc doesn't handle JALX
           Product: gdb
           Version: 6.8
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tdep
        AssignedTo: unassigned at sourceware dot org
        ReportedBy: bugs at ebshome dot net
                CC: gdb-prs at sourceware dot org
  GCC host triplet: mipsel-linux
GCC target triplet: mipsel-linux


http://sourceware.org/bugzilla/show_bug.cgi?id=9745

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug tdep/9745] mips32_next_pc doesn't handle JALX

[bugs at ebshome dot net]

------- Additional Comments From bugs at ebshome dot net  2009-01-15 02:50 -------
Created an attachment (id=3665)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3665&action=view)
mips-tdep.c: enable JALX handling in mips32_next_pc

I just moved JALX code to a proper place, tested on 4KEc based mipsel-linux
system

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9745

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug tdep/9745] mips32_next_pc doesn't handle JALX

[pedro at codesourcery dot com]

------- Additional Comments From pedro at codesourcery dot com  2009-01-15 09:24 -------
Subject: Re:  mips32_next_pc doesn't handle JALX

Hi!

Thanks for you contribution.  However, could you please test it
against current mainline, and post this patch at gdb-patches@, with
a ChangeLog entry ?  See src/gdb/CONTRIBUTE for guidelines.



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9745

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug tdep/9745] mips32_next_pc doesn't handle JALX

[bugs at ebshome dot net]

------- Additional Comments From bugs at ebshome dot net  2009-01-16 01:59 -------
Well, it'll take some time for me to test mainline, however I don't really
understand the reason to - I checked current trunk revision and it has the same
problem, mips32_next_pc is identical to 6.8 release, so it's a little puzzling
what difference it would make if I test this patch against mainline.

Also, do I understand this correctly that MIPS GDB maintainers don't check
Bugzilla? Is that the reason for re-posting this patch to gdb-patches@?

My only intention for posting this patch was that people responsible for MIPS
GDB support would look at it.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9745

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug tdep/9745] mips32_next_pc doesn't handle JALX

[pedro at codesourcery dot com]

------- Additional Comments From pedro at codesourcery dot com  2009-01-16 15:39 -------
Subject: Re:  mips32_next_pc doesn't handle JALX

On Friday 16 January 2009 01:59:13, bugs at ebshome dot net wrote:

> Well, it'll take some time for me to test mainline, however I don't really
> understand the reason to - I checked current trunk revision and it has the same
> problem, mips32_next_pc is identical to 6.8 release, so it's a little puzzling
> what difference it would make if I test this patch against mainline.

That's where the patch will be installed, if accepted.  It makes most sense
to me to make sure the patch works as intended against mainline.  The fact that
it applied cleanly doesn't mean that other changes elsewhere couldn't make
your patch behave differently from what you expected.

> Also, do I understand this correctly that MIPS GDB maintainers don't check
> Bugzilla? Is that the reason for re-posting this patch to gdb-patches@?

I can't speak for other people, I'm not a MIPS maintainer.  We just recently
switched to bugzilla from another tracker.  What I can say is, in the past, the old
tracker tended to be forgotten or ignored.  As a result, patches posted here tended to
go unnoticed.  People are slowly catching up, though, me included.

> My only intention for posting this patch was that people responsible for MIPS
> GDB support would look at it.

My only intention was to help you, in pointing you in the direction of how to
get the most attention to your patch.  In the end, you've gone through so much
trouble in getting this far, it would be a waste if nothing came out of it, right?



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9745

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug tdep/9745] mips32_next_pc doesn't handle JALX

[bugs at ebshome dot net]

------- Additional Comments From bugs at ebshome dot net  2009-01-16 16:56 -------
OK, fair enough.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9745

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.