[Bug tui/9068] segfault when navigating in 'layout asm'

[Bug tui/9068] segfault when navigating in 'layout asm'

[pedro at codesourcery dot com]

------- Additional Comments From pedro at codesourcery dot com  2009-01-18 21:38 -------
This crash disappeared when gdb's frame handling internals were revamped to make
it so that there's always a frame a few years back, and
deprecated_selected_frame was completely eliminated.  This meant that
this line:

    s = find_pc_symtab (get_frame_pc (deprecated_selected_frame));

which is touched in the proposed patch, looks like this in current sources:

    s = find_pc_symtab (get_frame_pc (get_selected_frame (NULL)));

get_selected_frame throws an error if there was no frame yet, so, no crash.

Now, of course that still isn't the best usability one would want.

Note that the propsed patch took care of vertical scroll, but I suspect that
horizontal scroll's implementation was also suffering from a possibly similar
problem.

I've checked in this patch: 

 http://sourceware.org/ml/gdb-patches/2009-01/msg00411.html

Which addresses the error one would now get in current mainline, and also tweaks
the vertical scrolling to make more sense, IMO, which was something that bugged
for long now.

I'm closing this issue.

Thanks!


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=9068

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.