[Bug gdb/11614] New: decode_variable() in linespec.c does not obey its contract

[Bug gdb/11614] New: decode_variable() in linespec.c does not obey its contract

[justin dot lebar+gdb at gmail dot com]

decode_variable() in linespec.c says that if |not_found_ptr| is non-null and the
function cannot be found, 1 is stored in the address referenced by
not_found_ptr, and an error message is not thrown.

In fact, an error message is thrown when the function is not found even if
|not_found_ptr| is non-null.

-- 
           Summary: decode_variable() in linespec.c does not obey its
                    contract
           Product: gdb
           Version: 7.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdb
        AssignedTo: unassigned at sourceware dot org
        ReportedBy: justin dot lebar+gdb at gmail dot com
                CC: gdb-prs at sourceware dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=11614

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug gdb/11614] decode_variable() in linespec.c does not obey its contract

[justin dot lebar+gdb at gmail dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |8287
              nThis|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=11614

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug gdb/11614] decode_variable() in linespec.c does not obey its contract

[justin dot lebar+gdb at gmail dot com]

------- Additional Comments From justin dot lebar+gdb at gmail dot com  2010-05-20 06:50 -------
Created an attachment (id=4804)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4804&action=view)
Patch v1

I ran the regression tests before and after applying this patch, and it's
unfortunately not entirely clear whether the patch causes a regression.

I *think* it's OK, because I ran it twice and got two non-overlapping sets of
failures compared to the unedited version.  But someone who understands this
better should probably double-check me.

In the interests of full disclosure: I haven't received the FSF copyright
paperwork yet.	I'll post here once I get it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at sourceware dot|justin dot lebar+gdb at
                   |org                         |gmail dot com
             Status|UNCONFIRMED                 |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=11614

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug gdb/11614] decode_variable() in linespec.c does not obey its contract

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=11614

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |tromey at redhat dot com
         Resolution|                            |FIXED
   Target Milestone|7.1                         |7.3

--- Comment #2 from Tom Tromey <tromey at redhat dot com> 2011-08-02 19:04:34 UTC ---
We removed the not_found_ptr code from linespec earlier this year.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.