[Bug mi/11738] -var-evaluate-expression doesn't work after removing pretty printer

[Bug mi/11738] -var-evaluate-expression doesn't work after removing pretty printer

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=11738

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I didn't set up a test case for a pointer pretty-printer,
but I wonder if invoking -var-update first would help.

I see this code in c-varobj.c:

            /* If the specified format is the current one,
               we can reuse print_value.  */
            if (format == var->format)
              return var->print_value;
            else
              return varobj_value_get_print_value (var->value.get (), format,
                                                   var);

So I suspect what's happening is that resetting the visualizer
does not change the print_value, and so then gdb thinks it
can just reuse the existing one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug mi/11738] -var-evaluate-expression doesn't work after removing pretty printer

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=11738

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-08-31
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I have a somewhat hacky patch for this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug mi/11738] -var-evaluate-expression doesn't work after removing pretty printer

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=11738

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d1369de649a9d19abae1012ef805aaa674314c0c

commit d1369de649a9d19abae1012ef805aaa674314c0c
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Aug 31 13:58:49 2023 -0600

    Fix bug in -var-evaluate-expression

    This bug points out that if one uses -var-set-visualizer with "None"
    -- to disable a pretty-printer for a varobj -- then
    -var-evaluate-expression will still use pretty-printing.

    This is a combination of bugs.  First, setting the visualizer does not
    update the display text; and second, computing the display text should
    use "raw" when Python is available but no visualizer is desired.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=11738
    Reviewed-by: Keith Seitz <keiths@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug mi/11738] -var-evaluate-expression doesn't work after removing pretty printer

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=11738

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|7.1                         |14.1
             Status|NEW                         |RESOLVED

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.