* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
@ 2013-11-04 13:02 ` gbenson at redhat dot com
2013-11-04 16:29 ` gbenson at redhat dot com
` (7 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: gbenson at redhat dot com @ 2013-11-04 13:02 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
Gary Benson <gbenson at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gbenson at redhat dot com
--- Comment #1 from Gary Benson <gbenson at redhat dot com> ---
See also bug 15548.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
2013-11-04 13:02 ` [Bug cli/11920] tab completion might stall cli without any feedback gbenson at redhat dot com
@ 2013-11-04 16:29 ` gbenson at redhat dot com
2014-02-12 11:40 ` gbenson at redhat dot com
` (6 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: gbenson at redhat dot com @ 2013-11-04 16:29 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
Gary Benson <gbenson at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |gbenson at redhat dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
2013-11-04 13:02 ` [Bug cli/11920] tab completion might stall cli without any feedback gbenson at redhat dot com
2013-11-04 16:29 ` gbenson at redhat dot com
@ 2014-02-12 11:40 ` gbenson at redhat dot com
2014-02-14 17:22 ` dmalcolm at redhat dot com
` (5 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: gbenson at redhat dot com @ 2014-02-12 11:40 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
Gary Benson <gbenson at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2014-02-12
Ever confirmed|0 |1
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
` (2 preceding siblings ...)
2014-02-12 11:40 ` gbenson at redhat dot com
@ 2014-02-14 17:22 ` dmalcolm at redhat dot com
2014-05-14 13:02 ` gbenson at redhat dot com
` (4 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: dmalcolm at redhat dot com @ 2014-02-14 17:22 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
Dave Malcolm <dmalcolm at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dmalcolm at redhat dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
` (3 preceding siblings ...)
2014-02-14 17:22 ` dmalcolm at redhat dot com
@ 2014-05-14 13:02 ` gbenson at redhat dot com
2014-09-21 8:54 ` maayan at maayank dot com
` (3 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: gbenson at redhat dot com @ 2014-05-14 13:02 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
Gary Benson <gbenson at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
Assignee|gbenson at redhat dot com |unassigned at sourceware dot org
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
` (4 preceding siblings ...)
2014-05-14 13:02 ` gbenson at redhat dot com
@ 2014-09-21 8:54 ` maayan at maayank dot com
2015-01-31 23:15 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: maayan at maayank dot com @ 2014-09-21 8:54 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
Maayan Keshet <maayan at maayank dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |maayan at maayank dot com
--- Comment #2 from Maayan Keshet <maayan at maayank dot com> ---
Maybe it's difficult to resolve thoroughly, as the problem is the amount of
symbol tables and not amount of symbols (so it can happen with vastly varying
amount of symbols).
But for the meantime, can we have an option to disable the tab completion when
the inputted prefix is < $SOME_NUM? e.g. if I enter the command "noshorttab"
and do "b foo<tab>" nothing will happen.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
` (5 preceding siblings ...)
2014-09-21 8:54 ` maayan at maayank dot com
@ 2015-01-31 23:15 ` cvs-commit at gcc dot gnu.org
2015-01-31 23:27 ` cvs-commit at gcc dot gnu.org
2015-03-28 22:13 ` xdje42 at gmail dot com
8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-01-31 23:15 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Doug Evans <devans@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ef0b411a110cd2602cb89c3fb237baf8beb28545
commit ef0b411a110cd2602cb89c3fb237baf8beb28545
Author: Gary Benson <gbenson@redhat.com>
Date: Sat Jan 31 15:07:22 2015 -0800
Add max-completions parameter, and implement tab-completion limiting.
This commit adds a new exception, MAX_COMPLETIONS_REACHED_ERROR, to be
thrown whenever the completer has generated too many candidates to
be useful. A new user-settable variable, "max_completions", is added
to control this behaviour. A top-level completion limit is added to
complete_line_internal, as the final check to ensure the user never
sees too many completions. An additional limit is added to
default_make_symbol_completion_list_break_on, to halt time-consuming
symbol table expansions.
gdb/ChangeLog:
PR cli/9007
PR cli/11920
PR cli/15548
* cli/cli-cmds.c (complete_command): Notify user if max-completions
reached.
* common/common-exceptions.h (enum errors)
<MAX_COMPLETIONS_REACHED_ERROR>: New value.
* completer.h (get_max_completions_reached_message): New declaration.
(max_completions): Likewise.
(completion_tracker_t): New typedef.
(new_completion_tracker): New declaration.
(make_cleanup_free_completion_tracker): Likewise.
(maybe_add_completion_enum): New enum.
(maybe_add_completion): New declaration.
(throw_max_completions_reached_error): Likewise.
* completer.c (max_completions): New global variable.
(new_completion_tracker): New function.
(free_completion_tracker): Likewise.
(make_cleanup_free_completion_tracker): Likewise.
(maybe_add_completions): Likewise.
(throw_max_completions_reached_error): Likewise.
(complete_line): Remove duplicates and limit result to max_completions
entries.
(get_max_completions_reached_message): New function.
(gdb_display_match_list): Handle max_completions.
(_initialize_completer): New declaration and function.
* symtab.c: Include completer.h.
(completion_tracker): New static variable.
(completion_list_add_name): Call maybe_add_completion.
(default_make_symbol_completion_list_break_on_1): Renamed from
default_make_symbol_completion_list_break_on. Maintain
completion_tracker across calls to completion_list_add_name.
(default_make_symbol_completion_list_break_on): New function.
* top.c (init_main): Set rl_completion_display_matches_hook.
* tui/tui-io.c: Include completer.h.
(tui_old_rl_display_matches_hook): New static global.
(tui_rl_display_match_list): Notify user if max-completions reached.
(tui_setup_io): Save/restore rl_completion_display_matches_hook.
* NEWS (New Options): Mention set/show max-completions.
gdb/doc/ChangeLog:
* gdb.texinfo (Command Completion): Document new
"set/show max-completions" option.
gdb/testsuite/ChangeLog:
* gdb.base/completion.exp: Disable completion limiting for
existing tests. Add new tests to check completion limiting.
* gdb.linespec/ls-errs.exp: Disable completion limiting.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
` (6 preceding siblings ...)
2015-01-31 23:15 ` cvs-commit at gcc dot gnu.org
@ 2015-01-31 23:27 ` cvs-commit at gcc dot gnu.org
2015-03-28 22:13 ` xdje42 at gmail dot com
8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-01-31 23:27 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Doug Evans <devans@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cfb069a8bebfacaf00dee6446e86a856978670be
commit cfb069a8bebfacaf00dee6446e86a856978670be
Author: Gary Benson <gbenson@redhat.com>
Date: Sat Jan 31 15:24:26 2015 -0800
ChangeLog entries for max-completions patch.
gdb/ChangeLog:
PR cli/9007
PR cli/11920
PR cli/15548
* cli/cli-cmds.c (complete_command): Notify user if max-completions
reached.
* common/common-exceptions.h (enum errors)
<MAX_COMPLETIONS_REACHED_ERROR>: New value.
* completer.h (get_max_completions_reached_message): New declaration.
(max_completions): Likewise.
(completion_tracker_t): New typedef.
(new_completion_tracker): New declaration.
(make_cleanup_free_completion_tracker): Likewise.
(maybe_add_completion_enum): New enum.
(maybe_add_completion): New declaration.
(throw_max_completions_reached_error): Likewise.
* completer.c (max_completions): New global variable.
(new_completion_tracker): New function.
(free_completion_tracker): Likewise.
(make_cleanup_free_completion_tracker): Likewise.
(maybe_add_completions): Likewise.
(throw_max_completions_reached_error): Likewise.
(complete_line): Remove duplicates and limit result to max_completions
entries.
(get_max_completions_reached_message): New function.
(gdb_display_match_list): Handle max_completions.
(_initialize_completer): New declaration and function.
* symtab.c: Include completer.h.
(completion_tracker): New static variable.
(completion_list_add_name): Call maybe_add_completion.
(default_make_symbol_completion_list_break_on_1): Renamed from
default_make_symbol_completion_list_break_on. Maintain
completion_tracker across calls to completion_list_add_name.
(default_make_symbol_completion_list_break_on): New function.
* top.c (init_main): Set rl_completion_display_matches_hook.
* tui/tui-io.c: Include completer.h.
(tui_old_rl_display_matches_hook): New static global.
(tui_rl_display_match_list): Notify user if max-completions reached.
(tui_setup_io): Save/restore rl_completion_display_matches_hook.
* NEWS (New Options): Mention set/show max-completions.
gdb/doc/ChangeLog:
* gdb.texinfo (Command Completion): Document new
"set/show max-completions" option.
gdb/testsuite/ChangeLog:
* gdb.base/completion.exp: Disable completion limiting for
existing tests. Add new tests to check completion limiting.
* gdb.linespec/ls-errs.exp: Disable completion limiting.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug cli/11920] tab completion might stall cli without any feedback
[not found] <bug-11920-4717@http.sourceware.org/bugzilla/>
` (7 preceding siblings ...)
2015-01-31 23:27 ` cvs-commit at gcc dot gnu.org
@ 2015-03-28 22:13 ` xdje42 at gmail dot com
8 siblings, 0 replies; 9+ messages in thread
From: xdje42 at gmail dot com @ 2015-03-28 22:13 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=11920
Doug Evans <xdje42 at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |xdje42 at gmail dot com
Resolution|--- |FIXED
--- Comment #5 from Doug Evans <xdje42 at gmail dot com> ---
Patch committed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread