[Bug win32/12716] addresses of exported symbols of a DLL should be looked up by ordinal

["mark at klomp dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=12716

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #6 from Mark Wielaard <mark at klomp dot org> ---
I can confirm that your paperwork is on file.
You submitted the patch and it was reviewed in this thread:
https://inbox.sourceware.org/gdb-patches/1307879815.1831.0.camel@t41.thuisdomein/

And it looks like something similar to (or inspired on) your patch was
committed as part of:

commit 3999122f0c8766df3a55462df626d607ebe5a735
Author: Pierre Muller <muller@sourceware.org>
Date:   Thu Dec 13 10:44:45 2012 +0000

            * coff-pe-read.h (pe_text_section_offset): Declare new function.
            * coff-pe-read.c (debug_coff_pe_read): New static variable.
            (struct read_pe_section_data): Add section_name field.
            (IMAGE_SCN_CNT_CODE): New macro, if not already defined.
            (IMAGE_SCN_CNT_INITIALIZED_DATA): Ditto.
            (IMAGE_SCN_CNT_UNINITIALIZED_DATA): Ditto.
            (get_pe_section_index): New function.
            (struct pe_sections_info): New type.
            (get_section_vmas): Use new struct pe_sections_info.
            (add_pe_exported_sym): Handle unnamed exported function.
            (add_pe_forwarded_sym): New function.
            (read_pe_truncate_name): Truncate at last dot.
            (pe_as16): New function.
            (read_pe_exported_syms): Use ordinal of function to
            retrieve correct RVA address of function and handle
            forwarded symbol.
            (pe_text_section_offset): New function.
            (show_debug_coff_pe_read): New function.
            (_initialize_coff_pe_read): New function adding
            'set/show debug coff_pe_read' commands.

            * windows-tdep.c (windows_xfer_shared_library): Use
            pe_text_section_offset function instead of possibly wrong
            0x1000 constant for .text sextion offset.

Which has a very long thread discussing it:
https://inbox.sourceware.org/gdb-patches/006001cdaada$00c81f00$02585d00$@muller@ics-cnrs.unistra.fr/t/#u

-- 
You are receiving this mail because:
You are on the CC list for the bug.