public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug build/12904] New: dwarf2loc.c uses return in void functions
@ 2011-06-16 20:17 tim.mooney at ndsu dot edu
2011-06-17 9:18 ` [Bug build/12904] " pedro at codesourcery dot com
2011-06-17 16:16 ` tim.mooney at ndsu dot edu
0 siblings, 2 replies; 3+ messages in thread
From: tim.mooney at ndsu dot edu @ 2011-06-16 20:17 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=12904
Summary: dwarf2loc.c uses return in void functions
Product: gdb
Version: 7.2
Status: NEW
Severity: minor
Priority: P2
Component: build
AssignedTo: unassigned@sourceware.org
ReportedBy: tim.mooney@ndsu.edu
Created attachment 5797
--> http://sourceware.org/bugzilla/attachment.cgi?id=5797
patch to remove "return" statements from two void functions
I'm building gdb-7.2 on x86_64-sun-solaris2.10 with the Sun Workshop 12u1
compiler toolchain.
gdb/dwarf2loc.c has a couple of functions that are "void", but for which the
function tries to return the result of some other function call.
That's illegal, and the return is superfluous in this case. Just call the
function without using "return".
Patch attached.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug build/12904] dwarf2loc.c uses return in void functions
2011-06-16 20:17 [Bug build/12904] New: dwarf2loc.c uses return in void functions tim.mooney at ndsu dot edu
@ 2011-06-17 9:18 ` pedro at codesourcery dot com
2011-06-17 16:16 ` tim.mooney at ndsu dot edu
1 sibling, 0 replies; 3+ messages in thread
From: pedro at codesourcery dot com @ 2011-06-17 9:18 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=12904
Pedro Alves <pedro at codesourcery dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |pedro at codesourcery dot
| |com
Resolution| |DUPLICATE
--- Comment #1 from Pedro Alves <pedro at codesourcery dot com> 2011-06-17 09:17:22 UTC ---
Already fixed on head and 7.2 branch.
*** This bug has been marked as a duplicate of bug 12576 ***
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug build/12904] dwarf2loc.c uses return in void functions
2011-06-16 20:17 [Bug build/12904] New: dwarf2loc.c uses return in void functions tim.mooney at ndsu dot edu
2011-06-17 9:18 ` [Bug build/12904] " pedro at codesourcery dot com
@ 2011-06-17 16:16 ` tim.mooney at ndsu dot edu
1 sibling, 0 replies; 3+ messages in thread
From: tim.mooney at ndsu dot edu @ 2011-06-17 16:16 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=12904
--- Comment #2 from tim.mooney at ndsu dot edu 2011-06-17 16:16:02 UTC ---
Thanks Pedro and sorry for the duplicate bug report. I did a search for
"dwarf2loc" in any comment before filing this bug, but I must have somehow
missed bug #12576.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-17 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-16 20:17 [Bug build/12904] New: dwarf2loc.c uses return in void functions tim.mooney at ndsu dot edu
2011-06-17 9:18 ` [Bug build/12904] " pedro at codesourcery dot com
2011-06-17 16:16 ` tim.mooney at ndsu dot edu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).