[Bug mi/14081] New: -file-list-exec-source-files should weed out duplicates

[Bug mi/14081] New: -file-list-exec-source-files should weed out duplicates

[dov.grobgeld at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14081

             Bug #: 14081
           Summary: -file-list-exec-source-files should weed out
                    duplicates
           Product: gdb
           Version: unknown
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mi
        AssignedTo: unassigned@sourceware.org
        ReportedBy: dov.grobgeld@gmail.com
    Classification: Unclassified


-file-list-exec-source-files currently does not run "uniq" on its output. The
result is that the same file names may appear multiple times. In an example run
on an executable from my work place, -file-list-exec-source-files generated a
text string 3.5MB in size. After postprocessing this file to remove duplicates,
the size was reduced to 220k.

I propose that mi_cmd_file_list_exec_source_files() be amended to keep a hash
table of filenames already output and skips outputting the same filename twice.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug mi/14081] -file-list-exec-source-files should weed out duplicates

[dov.grobgeld at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14081

--- Comment #1 from Dov Grobgeld <dov.grobgeld at gmail dot com> 2012-05-10 20:54:43 UTC ---
Created attachment 6405
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6405
Patch filtering out duplicate filenames.

This patch creates a hash table with all filenames encountered, and checks all
files if they have already been output. This prevents outputting the same name
twice.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug mi/14081] -file-list-exec-source-files should weed out duplicates

[dov.grobgeld at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14081

Dov Grobgeld <dov.grobgeld at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unknown                     |HEAD

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug mi/14081] -file-list-exec-source-files should weed out duplicates

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14081

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |tromey at sourceware dot org
             Status|NEW                         |RESOLVED

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I'm sorry nobody looked at this back in 2012.
Normally gdb does its patch review via the mailing list.

Anyway I think this feature was implemented separately,
maybe by

commit 9fdc877be243c5330410dd3274d583542e07737c
Author: Doug Evans <dje@google.com>
Date:   Fri Jul 13 18:41:21 2012 +0000

            * symtab.c (output_source_filename): Delete unnecessary forward
decl.
            (filename_seen_cache): New struct.
            (INITIAL_FILENAME_SEEN_CACHE_SIZE): New macro.
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.