[Bug breakpoints/14145] New: BranchDest at arm-tdep.c overflowed

[Bug breakpoints/14145] New: BranchDest at arm-tdep.c overflowed

[manjian2006 at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14145

             Bug #: 14145
           Summary: BranchDest at arm-tdep.c overflowed
           Product: gdb
           Version: 7.4
            Status: NEW
          Severity: critical
          Priority: P2
         Component: breakpoints
        AssignedTo: unassigned@sourceware.org
        ReportedBy: manjian2006@gmail.com
    Classification: Unclassified


BranchDest was intended to find the branch address from the instruction
provided.But its define:

#define BranchDest(addr,instr) \
  ((CORE_ADDR) (((long) (addr)) + 8 + (sbits (instr, 0, 23) << 2)))
tried to convert the 32-bit integer to 64-bit integer without considering the
overflow,which caused the result which has signed bit(e.g 0x859127d4) expanded
its higher bits to 0xffffffff (e.g. 0xffffffff859127d4).

The solution is to fix the define like this

  ((CORE_ADDR) (((CORE_ADDR) (addr)) + 8 + (sbits (instr, 0, 23) << 2)))

This bug might result in failing to execute the "next" command in the machine
which had no hardware debug registers.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/14145] BranchDest at arm-tdep.c overflowed

[will.newton at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14145

Will Newton <will.newton at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |will.newton at gmail dot com
         Resolution|---                         |FIXED

--- Comment #1 from Will Newton <will.newton at gmail dot com> ---

This issue was fixed in commit 9991b20795a23272b07dd2214aa3ee0196b61f0b.

-- 
You are receiving this mail because:
You are on the CC list for the bug.