[Bug tdep/14222] New: insufficient stack alignment

[Bug tdep/14222] New: insufficient stack alignment

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14222

             Bug #: 14222
           Summary: insufficient stack alignment
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tdep
        AssignedTo: unassigned@sourceware.org
        ReportedBy: jan.kratochvil@redhat.com
    Classification: Unclassified
            Target: i386-unknown-linux-gnu


GCC since 4.6 keeps stack aligned to 32 bytes (128 bits).
http://groups.google.com/group/ia32-abi/browse_thread/thread/4f9b3e5069943bf1

AFAIK there is neither Intel CPUs nor glibc requirement for it, 16 bytes
alignment would be sufficient.

amd64-tdep.c already keeps 16 byte alignment but i386-tdep.c does not.
Proposing to increase alignment of both to 32 bytes in all cases.

This is KFAIL tracker for: gdb.arch/i386-sse-stack-align.exp

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug tdep/14222] insufficient stack alignment

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14222

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at sourceware    |jan.kratochvil at redhat
                   |dot org                     |dot com

--- Comment #1 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2012-06-13 15:53:32 UTC ---
[patch 2/3] Align stack for SSE (PR tdep/14222)
http://sourceware.org/ml/gdb-patches/2012-06/msg00418.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug tdep/14222] insufficient stack alignment

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14222

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-06-13 21:21:29 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    kettenis@sourceware.org    2012-06-13 21:21:25

Modified files:
    gdb            : ChangeLog i386-tdep.c 

Log message:
    PR tdep/14222
    * i386-tdep.c (i386_push_dummy_call): Unconditionally align the
    stack on a 16-byte boundary.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14362&r2=1.14363
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/i386-tdep.c.diff?cvsroot=src&r1=1.352&r2=1.353

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug tdep/14222] insufficient stack alignment

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14222

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-06-13 21:31:14 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    jkratoch@sourceware.org    2012-06-13 21:31:06

Modified files:
    gdb/testsuite  : ChangeLog 
Added files:
    gdb/testsuite/gdb.arch: i386-sse-stack-align.S 
                            i386-sse-stack-align.c 
                            i386-sse-stack-align.exp 

Log message:
    gdb/testsuite/
    PR tdep/14222
    * gdb.arch/i386-sse-stack-align.S: New file.
    * gdb.arch/i386-sse-stack-align.c: New file.
    * gdb.arch/i386-sse-stack-align.exp: New file.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3224&r2=1.3225
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/i386-sse-stack-align.S.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/i386-sse-stack-align.c.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp.diff?cvsroot=src&r1=NONE&r2=1.1

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug tdep/14222] insufficient stack alignment

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14222

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2012-06-13 21:31:53 UTC ---
Checked in.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.