[Bug cli/14392] New: list ,5 crashes GDB with a SEGFAULT

[Bug cli/14392] New: list ,5 crashes GDB with a SEGFAULT

[kevin.pouget at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14392

             Bug #: 14392
           Summary: list ,5 crashes GDB with a SEGFAULT
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cli
        AssignedTo: unassigned@sourceware.org
        ReportedBy: kevin.pouget@gmail.com
    Classification: Unclassified


`help list` specifies that last can have two arguments:

> One argument specifies a line, and ten lines are listed around that line.
> Two arguments with comma between specify starting and ending lines to list.

But if you forget the first argument, GDB crashes with a SEGFAULT:

$ where
#0  0x00000000004d8947 in filter_sals (sals=0x7fff2b82f4d0)    at
.../gdb/cli/cli-cmds.c:1521
#1  0x00000000004d7664 in list_command (arg=0xc83732 ",5", from_tty=1)    at
.../gdb/cli/cli-cmds.c:964

it looks like `sals` is never initialized when the arguments starts with a ','.

GDB HEAD is affected, but not the one from Fedora 17 package
(7.4.50.20120120-49.fc17)

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug cli/14392] list ,5 crashes GDB with a SEGFAULT

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14392

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at redhat dot com
         AssignedTo|unassigned at sourceware    |tromey at redhat dot com
                   |dot org                     |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug cli/14392] list ,5 crashes GDB with a SEGFAULT

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14392

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jan.kratochvil at redhat
                   |                            |dot com

--- Comment #1 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2012-08-05 19:49:03 UTC ---
Fix PR 14392
http://sourceware.org/ml/gdb-patches/2012-07/msg00800.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug cli/14392] list ,5 crashes GDB with a SEGFAULT

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14392

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-08-06 18:28:23 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    tromey@sourceware.org    2012-08-06 18:28:16

Modified files:
    gdb            : ChangeLog 
    gdb/cli        : cli-cmds.c 

Log message:
    PR cli/14392:
    * cli/cli-cmds.c (list_command): Filter 'sals_end'.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14560&r2=1.14561
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/cli/cli-cmds.c.diff?cvsroot=src&r1=1.133&r2=1.134

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug cli/14392] list ,5 crashes GDB with a SEGFAULT

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14392

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-08-06 18:34:02 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Branch:     gdb_7_5-branch
Changes by:    tromey@sourceware.org    2012-08-06 18:33:57

Modified files:
    gdb            : ChangeLog 
    gdb/cli        : cli-cmds.c 

Log message:
    PR cli/14392:
    * cli/cli-cmds.c (list_command): Filter 'sals_end'.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=1.14469.2.19&r2=1.14469.2.20
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/cli/cli-cmds.c.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=1.131&r2=1.131.2.1

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug cli/14392] list ,5 crashes GDB with a SEGFAULT

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14392

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |7.5

--- Comment #4 from Tom Tromey <tromey at redhat dot com> 2012-08-06 18:35:38 UTC ---
Fixed.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.