[Bug mi/14741] New: in -var-update, all children get the display hint and dynamic attribute value from the root variable

[Bug mi/14741] New: in -var-update, all children get the display hint and dynamic attribute value from the root variable

[jens.elmenthaler at advantest dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14741

             Bug #: 14741
           Summary: in -var-update, all children get the display hint and
                    dynamic attribute value from the root variable
           Product: gdb
           Version: 7.5
            Status: NEW
          Severity: critical
          Priority: P2
         Component: mi
        AssignedTo: unassigned@sourceware.org
        ReportedBy: jens.elmenthaler@advantest.com
    Classification: Unclassified


Created attachment 6690
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6690
Proposed fix

in varobj_update_one(), when dumping the display hint and dynamic attribute,
the value from the updated root value is inserted for each child update,
instead of the values from the actual child.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug mi/14741] in -var-update, all children get the display hint and dynamic attribute value from the root variable

[marc.khouzam at ericsson dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14741

Marc Khouzam <marc.khouzam at ericsson dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marc.khouzam at ericsson
                   |                            |dot com

--- Comment #1 from Marc Khouzam <marc.khouzam at ericsson dot com> 2012-10-18 19:13:32 UTC ---
This bug can be seen in Eclipse by preventing the user from modifying the
content of an STL properly.

I can confirm that using the proposed patch makes it go away.

See details in: 
https://bugs.eclipse.org/392064

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug mi/14741] in -var-update, all children get the display hint and dynamic attribute value from the root variable

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14741

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-12-06 19:00:01 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    tromey@sourceware.org    2012-12-06 18:59:57

Modified files:
    gdb            : ChangeLog 
    gdb/mi         : mi-cmd-var.c 
    gdb/testsuite  : ChangeLog 
    gdb/testsuite/gdb.python: py-mi.exp py-prettyprint.c 
                              py-prettyprint.py 

Log message:
    2012-12-06  Jens Elmenthaler <jens.elmenthaler@advantest.com>

    PR mi/14741:
    * mi/mi-cmd-var.c (varobj_update_one): Take value of
    attribute "dynamic" and "displayhint" from printed child,
    not the root variable.

    * gdb.python/py-mi.exp: Correct expected results for attribute
    "dynamic" returned by -var-update.
    Add test case for correct handling of "diplayhint" for children
    of dynamic varobjs.
    * gdb.python/py-prettyprint.c (set_itme): New function.
    (bug_14741) New function.
    (main) Add call to bug_14741().
    * gdb.python/py-prettyprint.py (class ArrayPrinter): New class.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14885&r2=1.14886
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/mi/mi-cmd-var.c.diff?cvsroot=src&r1=1.76&r2=1.77
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3473&r2=1.3474
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.python/py-mi.exp.diff?cvsroot=src&r1=1.17&r2=1.18
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.python/py-prettyprint.c.diff?cvsroot=src&r1=1.16&r2=1.17
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.python/py-prettyprint.py.diff?cvsroot=src&r1=1.15&r2=1.16

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug mi/14741] in -var-update, all children get the display hint and dynamic attribute value from the root variable

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14741

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |tromey at redhat dot com
         Resolution|                            |FIXED
   Target Milestone|---                         |7.6

--- Comment #3 from Tom Tromey <tromey at redhat dot com> 2012-12-06 19:04:48 UTC ---
Fix checked in.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.