[Bug breakpoints/15165] New: problems saving dprintf breakpoints

[Bug breakpoints/15165] New: problems saving dprintf breakpoints

[keiths at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15165

             Bug #: 15165
           Summary: problems saving dprintf breakpoints
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: breakpoints
        AssignedTo: unassigned@sourceware.org
        ReportedBy: keiths@redhat.com
    Classification: Unclassified


(gdb) dprintf main,"hello"
Dprintf 1 at 0x4004dc: file comma.cc, line 13.
(gdb) save breakpoints bps
../../gdb/gdb/breakpoint.c:13309: internal-error: unhandled breakpoint type 29
A problem internal to GDB has been detected,
further debugging may prove unreliable.

We need to add a dprintf_print_recreate to "do the right thing."

There are no tests for this in the test suite at all (or the internal error
would have been seen long before now).

As a side note, simply adding bp_dprintf to the if/else chain in
bkpt_print_recreate isn't sufficient. It produces output like:
dprintf main
commands
  printf "hello"
  continue
end

which is invalid input. [dprintf /must/ have a format string argument]

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/15165] problems saving dprintf breakpoints

[marc.khouzam at ericsson dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15165

Marc Khouzam <marc.khouzam at ericsson dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marc.khouzam at ericsson
                   |                            |dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/15165] problems saving dprintf breakpoints

[teawater at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15165

teawater <teawater at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |teawater at gmail dot com

--- Comment #1 from teawater <teawater at gmail dot com> 2013-04-18 05:38:30 UTC ---
http://sourceware.org/ml/gdb-patches/2013-04/msg00548.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/15165] problems saving dprintf breakpoints

[teawater at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15165

teawater <teawater at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at sourceware    |teawater at gmail dot com
                   |dot org                     |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/15165] problems saving dprintf breakpoints

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15165

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2013-04-23 02:42:46 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    teawater@sourceware.org    2013-04-23 02:42:44

Modified files:
    gdb            : ChangeLog breakpoint.c 
    gdb/testsuite  : ChangeLog 
    gdb/testsuite/gdb.base: save-bp.exp 

Log message:
    2013-04-23  Hui Zhu  <hui@codesourcery.com>

    PR gdb/15165

    * breakpoint.c (dprintf_print_recreate): New.
    (save_breakpoints): Let it not save dprintf commands.
    (initialize_breakpoint_ops): Set dprintf_print_recreate.

    2013-04-23  Hui Zhu  <hui@codesourcery.com>

    PR gdb/15165

    * gdb.base/save-bp.exp: Add test for dprintf.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15466&r2=1.15467
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/breakpoint.c.diff?cvsroot=src&r1=1.756&r2=1.757
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3634&r2=1.3635
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/save-bp.exp.diff?cvsroot=src&r1=1.4&r2=1.5

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/15165] problems saving dprintf breakpoints

[teawater at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15165

teawater <teawater at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from teawater <teawater at gmail dot com> 2013-04-23 03:05:20 UTC ---
http://sourceware.org/ml/gdb-cvs/2013-04/msg00221.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/15165] problems saving dprintf breakpoints

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15165

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2013-04-24 06:20:31 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Branch:     gdb_7_6-branch
Changes by:    teawater@sourceware.org    2013-04-24 06:20:29

Modified files:
    gdb            : breakpoint.c ChangeLog 
    gdb/testsuite/gdb.base: save-bp.exp 
    gdb/testsuite  : ChangeLog 

Log message:
    2013-04-24  Hui Zhu  <hui@codesourcery.com>

    PR gdb/15165

    * breakpoint.c (dprintf_print_recreate): New.
    (save_breakpoints): Let it not save dprintf commands.
    (initialize_breakpoint_ops): Set dprintf_print_recreate.

    2013-04-24  Hui Zhu  <hui@codesourcery.com>

    PR gdb/15165

    * gdb.base/save-bp.exp: Add test for dprintf.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/breakpoint.c.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.745.2.2&r2=1.745.2.3
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.15260.2.41&r2=1.15260.2.42
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/save-bp.exp.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.4&r2=1.4.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.3580.2.15&r2=1.3580.2.16

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.