public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug remote/15455] New: QTro remote packet broken
@ 2013-05-10 9:11 palves at redhat dot com
2013-05-10 9:11 ` [Bug remote/15455] " palves at redhat dot com
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: palves at redhat dot com @ 2013-05-10 9:11 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=15455
Bug #: 15455
Summary: QTro remote packet broken
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: remote
AssignedTo: unassigned@sourceware.org
ReportedBy: palves@redhat.com
Classification: Unclassified
>From http://sourceware.org/ml/gdb-patches/2013-05/msg00009.html:
In function remote_trace_set_readonly_regions in gdb/remote.c, the local
variable 'offset' does not account for "QTro" at the start of the packet
with the result that if there are any read-only regions, the packet is
sent -- but without the "QTro" -- causing the remote stub to report that
the packet is unsupported.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/15455] QTro remote packet broken
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
@ 2013-05-10 9:11 ` palves at redhat dot com
2013-05-10 9:28 ` palves at redhat dot com
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: palves at redhat dot com @ 2013-05-10 9:11 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=15455
Pedro Alves <palves at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|HEAD |7.6
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/15455] QTro remote packet broken
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
2013-05-10 9:11 ` [Bug remote/15455] " palves at redhat dot com
@ 2013-05-10 9:28 ` palves at redhat dot com
2013-05-10 9:29 ` palves at redhat dot com
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: palves at redhat dot com @ 2013-05-10 9:28 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=15455
Pedro Alves <palves at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dtaylor at emc dot com
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/15455] QTro remote packet broken
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
2013-05-10 9:11 ` [Bug remote/15455] " palves at redhat dot com
2013-05-10 9:28 ` palves at redhat dot com
@ 2013-05-10 9:29 ` palves at redhat dot com
2013-05-10 9:29 ` palves at redhat dot com
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: palves at redhat dot com @ 2013-05-10 9:29 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=15455
Pedro Alves <palves at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at sourceware |palves at redhat dot com
|dot org |
Target Milestone|--- |7.6
--- Comment #1 from Pedro Alves <palves at redhat dot com> 2013-05-10 09:29:08 UTC ---
Working on adding test to testsuite.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/15455] QTro remote packet broken
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
` (2 preceding siblings ...)
2013-05-10 9:29 ` palves at redhat dot com
@ 2013-05-10 9:29 ` palves at redhat dot com
2013-05-10 13:51 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: palves at redhat dot com @ 2013-05-10 9:29 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=15455
Pedro Alves <palves at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/15455] QTro remote packet broken
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
` (3 preceding siblings ...)
2013-05-10 9:29 ` palves at redhat dot com
@ 2013-05-10 13:51 ` cvs-commit at gcc dot gnu.org
2013-05-10 13:59 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2013-05-10 13:51 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=15455
--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2013-05-10 13:51:50 UTC ---
CVSROOT: /cvs/src
Module name: src
Branch: gdb_7_6-branch
Changes by: palves@sourceware.org 2013-05-10 13:51:49
Modified files:
gdb : ChangeLog remote.c
gdb/testsuite : ChangeLog
Added files:
gdb/testsuite/gdb.trace: qtro.c qtro.exp
Log message:
PR remote/15455 - QTro remote packet broken
In the function remote_trace_set_readonly_regions in gdb/remote.c, the
local variable 'offset' does not account for "QTro" at the start of
the packet with the result that if there are any read-only regions,
the packet is sent -- but without the "QTro" -- causing the remote
stub to report that the packet is unsupported:
Sending packet: $:0000000000400200,(...),00000000004560a4#ab...Packet
received:
vs the expected:
Sending packet: $QTro:0000000000400200,(...),00000000004560a4#31...Packet
received: OK
We don't see the problem when testing with GDBserver, as that supports
qXfer:trace-frame-info:read, meaning GDBserver never needs to read
from the read-only sections directly itself. This commit adds a test
that explicitly disables qXfer:trace-frame-info:read.
gdb/
2013-05-10 David Taylor <dtaylor@emc.com>
PR remote/15455
* remote.c (remote_trace_set_readonly_regions): Do not overwrite
"QTro" at start of packet.
gdb/testsuite/
2013-05-10 Pedro Alves <palves@redhat.com>
PR remote/15455
* gdb.trace/qtro.c: New file.
* gdb.trace/qtro.exp: New file.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.15260.2.52&r2=1.15260.2.53
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/remote.c.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.528.2.6&r2=1.528.2.7
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.3580.2.21&r2=1.3580.2.22
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.trace/qtro.c.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=NONE&r2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.trace/qtro.exp.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=NONE&r2=1.1.2.1
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/15455] QTro remote packet broken
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
` (4 preceding siblings ...)
2013-05-10 13:51 ` cvs-commit at gcc dot gnu.org
@ 2013-05-10 13:59 ` cvs-commit at gcc dot gnu.org
2013-05-10 14:50 ` palves at redhat dot com
2021-11-09 8:31 ` johnsjvi95 at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2013-05-10 13:59 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=15455
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2013-05-10 13:59:47 UTC ---
CVSROOT: /cvs/src
Module name: src
Changes by: palves@sourceware.org 2013-05-10 13:59:45
Modified files:
gdb : ChangeLog remote.c
gdb/testsuite : ChangeLog
Added files:
gdb/testsuite/gdb.trace: qtro.c qtro.exp
Log message:
PR remote/15455 - QTro remote packet broken
In the function remote_trace_set_readonly_regions in gdb/remote.c, the
local variable 'offset' does not account for "QTro" at the start of
the packet with the result that if there are any read-only regions,
the packet is sent -- but without the "QTro" -- causing the remote
stub to report that the packet is unsupported:
Sending packet: $:0000000000400200,(...),00000000004560a4#ab...Packet
received:
vs the expected:
Sending packet: $QTro:0000000000400200,(...),00000000004560a4#31...Packet
received: OK
We don't see the problem when testing with GDBserver, as that supports
qXfer:trace-frame-info:read, meaning GDBserver never needs to read
from the read-only sections directly itself. This commit adds a test
that explicitly disables qXfer:trace-frame-info:read.
gdb/
2013-05-10 David Taylor <dtaylor@emc.com>
PR remote/15455
* remote.c (remote_trace_set_readonly_regions): Do not overwrite
"QTro" at start of packet.
gdb/testsuite/
2013-05-10 Pedro Alves <palves@redhat.com>
PR remote/15455
* gdb.trace/qtro.c: New file.
* gdb.trace/qtro.exp: New file.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15543&r2=1.15544
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/remote.c.diff?cvsroot=src&r1=1.544&r2=1.545
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3654&r2=1.3655
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.trace/qtro.c.diff?cvsroot=src&r1=1.1&r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.trace/qtro.exp.diff?cvsroot=src&r1=1.1&r2=1.2
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/15455] QTro remote packet broken
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
` (5 preceding siblings ...)
2013-05-10 13:59 ` cvs-commit at gcc dot gnu.org
@ 2013-05-10 14:50 ` palves at redhat dot com
2021-11-09 8:31 ` johnsjvi95 at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: palves at redhat dot com @ 2013-05-10 14:50 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=15455
Pedro Alves <palves at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|7.6 |7.7
--- Comment #4 from Pedro Alves <palves at redhat dot com> 2013-05-10 14:50:41 UTC ---
Patch checked in.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/15455] QTro remote packet broken
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
` (6 preceding siblings ...)
2013-05-10 14:50 ` palves at redhat dot com
@ 2021-11-09 8:31 ` johnsjvi95 at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: johnsjvi95 at gmail dot com @ 2021-11-09 8:31 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=15455
Stewart <johnsjvi95 at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |johnsjvi95 at gmail dot com
--- Comment #5 from Stewart <johnsjvi95 at gmail dot com> ---
We don't see the problem when testing with GDBserver, as that supports
qXfer:trace-frame-info:read, meaning GDBserver never needs to read
from the read-only sections directly itself. This commit adds a test
that explicitly disables qXfer:trace-frame-info:read.
https://augustatreepros.com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-11-09 8:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-10 9:11 [Bug remote/15455] New: QTro remote packet broken palves at redhat dot com
2013-05-10 9:11 ` [Bug remote/15455] " palves at redhat dot com
2013-05-10 9:28 ` palves at redhat dot com
2013-05-10 9:29 ` palves at redhat dot com
2013-05-10 9:29 ` palves at redhat dot com
2013-05-10 13:51 ` cvs-commit at gcc dot gnu.org
2013-05-10 13:59 ` cvs-commit at gcc dot gnu.org
2013-05-10 14:50 ` palves at redhat dot com
2021-11-09 8:31 ` johnsjvi95 at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).