[Bug server/15604] New: [7.5 regression] gdbserver leaks socket to inferior

[Bug server/15604] New: [7.5 regression] gdbserver leaks socket to inferior

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15604

            Bug ID: 15604
           Summary: [7.5 regression] gdbserver leaks socket to inferior
           Product: gdb
           Version: 7.5
            Status: NEW
          Severity: normal
          Priority: P2
         Component: server
          Assignee: unassigned at sourceware dot org
          Reporter: jan.kratochvil at redhat dot com
                CC: dje at google dot com
              Host: x86_64-unknown-linux-gnu
            Target: x86_64-unknown-linux-gnu

gdbserver :1234 true & sleep 1;ls -l /proc/`pidof true`/fd/4

7.4 PASS: ls: cannot access /proc/25283/fd/3: No such file or directory
7.5 FAIL: lrwx------ 1 64 Jun 11 19:56 /proc/25283/fd/3 -> socket:[428409464]
7.6 FAIL


dc13f571984e51e99fef1f49b39c3c3b1a0119f6 is the first bad commit
commit dc13f571984e51e99fef1f49b39c3c3b1a0119f6
Author: Doug Evans <dje@google.com>
Date:   Fri Dec 16 19:06:34 2011 +0000
        * NEWS: Add entry for stdio gdbserver.
[RFA] stdio gdbserver
http://sourceware.org/ml/gdb-patches/2011-12/msg00022.html
Message-Id: <20111201212632.E6F892461D0@ruffy.mtv.corp.google.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/15604] [7.5 regression] gdbserver leaks socket to inferior

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15604

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jan.kratochvil at redhat dot com
           Assignee|unassigned at sourceware dot org   |jan.kratochvil at redhat dot com

--- Comment #1 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
[gdbserver patch] [7.6.1] Fix fd leak regression
https://sourceware.org/ml/gdb-patches/2013-08/msg00765.html
Message-ID: <20130826202121.GA31493@host2.jankratochvil.net>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/15604] [7.5 regression] gdbserver leaks socket to inferior

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15604

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    jkratoch@sourceware.org    2013-08-28 17:40:58

Modified files:
    gdb/gdbserver  : ChangeLog linux-low.c lynx-low.c server.c 
                     spu-low.c 

Log message:
    PR server/15604

    gdb/gdbserver/
    2013-08-28  Jan Kratochvil  <jan.kratochvil@redhat.com>

    PR server/15604
    * linux-low.c: Include filestuff.h.
    (linux_create_inferior) <pid == 0>: Call close_most_fds.
    * lynx-low.c: Include filestuff.h.
    (lynx_create_inferior) <pid == 0>: Call close_most_fds.
    * server.c: Include filestuff.h.
    (main): Call notice_open_fds.
    * spu-low.c: Include filestuff.h.
    (spu_create_inferior) <pid == 0>: Call close_most_fds.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/ChangeLog.diff?cvsroot=src&r1=1.750&r2=1.751
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/linux-low.c.diff?cvsroot=src&r1=1.245&r2=1.246
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/lynx-low.c.diff?cvsroot=src&r1=1.21&r2=1.22
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/server.c.diff?cvsroot=src&r1=1.195&r2=1.196
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/spu-low.c.diff?cvsroot=src&r1=1.43&r2=1.44

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/15604] [7.5 regression] gdbserver leaks socket to inferior

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15604

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|7.6                         |7.7

--- Comment #3 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
Checked in without 7.6.1 - 7.6 does not yet have gdb/common/filestuff.[ch] and
from various available solutions I think it is just OK to wait for 7.7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/15604] [7.5 regression] gdbserver leaks socket to inferior

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15604

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
CVSROOT:    /cvs/src
Module name:    src
Branch:     gdb_7_6-branch
Changes by:    jkratoch@sourceware.org    2013-08-29 14:24:16

Modified files:
    gdb/gdbserver  : ChangeLog linux-low.c lynx-low.c remote-utils.c 
                     server.h spu-low.c 

Log message:
    PR server/15604

    gdb/gdbserver/
    2013-08-29  Jan Kratochvil  <jan.kratochvil@redhat.com>

    PR server/15604
    * linux-low.c
    (linux_create_inferior) <pid == 0 && !remote_connection_is_stdio ()>:
    Close LISTEN_DESC and optionally REMOTE_DESC.
    (lynx_create_inferior) <pid == 0 && !remote_connection_is_stdio ()>:
    Close LISTEN_DESC and optionally REMOTE_DESC.
    * remote-utils.c (remote_desc, listen_desc): Remove static qualifier.
    * server.h (remote_desc, listen_desc): New declaration.
    * spu-low.c
    (spu_create_inferior) <pid == 0 && !remote_connection_is_stdio ()>:
    Close LISTEN_DESC and optionally REMOTE_DESC.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.697.2.6&r2=1.697.2.7
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/linux-low.c.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.233.2.1&r2=1.233.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/lynx-low.c.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.18&r2=1.18.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/remote-utils.c.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.96&r2=1.96.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/server.h.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.106&r2=1.106.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/spu-low.c.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.42&r2=1.42.2.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/15604] [7.5 regression] gdbserver leaks socket to inferior

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15604

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|7.7                         |7.6

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/15604] [7.5 regression] gdbserver leaks socket to inferior

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15604

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|7.6                         |7.6.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.