[Bug gdb/16015] New: Coding error: 6 * possibly faulty if statement ?

[Bug gdb/16015] New: Coding error: 6 * possibly faulty if statement ?

[dcb314 at hotmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16015

            Bug ID: 16015
           Summary: Coding error: 6 * possibly faulty if statement ?
           Product: gdb
           Version: 7.6
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: dcb314 at hotmail dot com

Some possible problems picked up in static analysis by cppcheck.

[gdb-7.6.1/gdb/h8300-tdep.c:204]: (warning) Logical conjunction always
evaluates to false: disp < 0 && disp > 16777215.
[gdb-7.6.1/gdb/h8300-tdep.c:223]: (warning) Logical conjunction always
evaluates to false: disp < 0 && disp > 16777215.
[gdb-7.6.1/gdb/h8300-tdep.c:247]: (warning) Logical conjunction always
evaluates to false: disp < 0 && disp > 16777215.
[gdb-7.6.1/sim/rx/reg.c:256]: (warning) Logical disjunction always evaluates to
true: id >= 1 || id <= 15.
[gdb-7.6.1/gdb/gdbserver/ax.c:83]: (warning) Logical disjunction always
evaluates to true: op >= 0 || op < 0.
[gdb-7.6.1/gdb/testsuite/gdb.base/print-file-var-main.c:29]: (warning) Logical
disjunction always evaluates to true: v2 != 104 || v2 != 203.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/16015] Coding error: 6 * possibly faulty if statement ?

[sergiodj at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16015

Sergio Durigan Junior <sergiodj at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergiodj at redhat dot com

--- Comment #1 from Sergio Durigan Junior <sergiodj at redhat dot com> ---
Thanks for the report.  The last but one warning (re.
gdb-7.6.1/gdb/gdbserver/ax.c:83) can be ignored because cppcheck can't expand
the macro and include the .def file to know that there will be other items in
the enum.

The other warnings are indeed true, but I would have to check with the
maintainers of h8300-tdep.c and sim/rx/reg.c to check for the fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/16015] Coding error: 6 * possibly faulty if statement ?

[dcb314 at hotmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16015

--- Comment #2 from dcb <dcb314 at hotmail dot com> ---
First three and the last one still broken, some years later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/16015] Coding error: 6 * possibly faulty if statement ?

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16015

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |tromey at sourceware dot org
             Status|NEW                         |RESOLVED

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
I think we fixed all of these.

-- 
You are receiving this mail because:
You are on the CC list for the bug.