public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug gdb/16189] New: gdbarch_skip_prologue() needs extra argument to handle overlay cases
@ 2013-11-19  0:12 arnab at cadence dot com
  2020-09-21  8:49 ` [Bug gdb/16189] " andrew.burgess at embecosm dot com
  0 siblings, 1 reply; 2+ messages in thread
From: arnab at cadence dot com @ 2013-11-19  0:12 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=16189

            Bug ID: 16189
           Summary: gdbarch_skip_prologue() needs extra argument to handle
                    overlay cases
           Product: gdb
           Version: 7.6
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: arnab at cadence dot com

gdbarch_skip_prologue() only takes the architecture and the PC value. In the
presence of overlays, the PC value is not unique and therefore not sufficient
to locate the function unambiguously. I suggest that this function be changed
to accept an additional argument, a pointer to a section, like so -

extern CORE_ADDR gdbarch_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR ip,
struct obj_section *section);

The PC value and the section together can identify the function uniquely.
Looking that the code that calls gdbarch_skip_prologue(), the section should be
known (or can be found) fairly easily. Most of the target-specific
implementations of skip_prologue() will end up not using this extra argument,
but those that need to will be able to.

Feel free to assign this to me for fixing, if you wish. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug gdb/16189] gdbarch_skip_prologue() needs extra argument to handle overlay cases
  2013-11-19  0:12 [Bug gdb/16189] New: gdbarch_skip_prologue() needs extra argument to handle overlay cases arnab at cadence dot com
@ 2020-09-21  8:49 ` andrew.burgess at embecosm dot com
  0 siblings, 0 replies; 2+ messages in thread
From: andrew.burgess at embecosm dot com @ 2020-09-21  8:49 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=16189

Andrew Burgess <andrew.burgess at embecosm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.burgess at embecosm dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-21  8:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-19  0:12 [Bug gdb/16189] New: gdbarch_skip_prologue() needs extra argument to handle overlay cases arnab at cadence dot com
2020-09-21  8:49 ` [Bug gdb/16189] " andrew.burgess at embecosm dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).