public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "pmuldoon at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug python/16324] py-finishbreakpoint.c incorrect frame_id_eq
Date: Mon, 24 Feb 2014 13:02:00 -0000 [thread overview]
Message-ID: <bug-16324-4717-hqicC63qMl@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-16324-4717@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=16324
Phil Muldoon <pmuldoon at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |pmuldoon at redhat dot com
Assignee|unassigned at sourceware dot org |pmuldoon at redhat dot com
--- Comment #1 from Phil Muldoon <pmuldoon at redhat dot com> ---
It seems the correct test here is to use frame_id_p which checks if a valid
stack is found (with a simple check to frame_id.stack_status !=
FID_STACK_INVALID). It also checks the frame_id is not an outer frame id.
There is no explicit check for a null_frame_id, which I found odd. get_frame_id
can return a null_frame_id, but lots of callers don't check the return so there
is a latent bug there too.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2014-02-24 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 11:25 [Bug python/16324] New: " jan.kratochvil at redhat dot com
2014-02-24 13:02 ` pmuldoon at redhat dot com [this message]
2022-06-05 16:24 ` [Bug python/16324] " tromey at sourceware dot org
2022-10-18 16:33 ` cvs-commit at gcc dot gnu.org
2022-10-18 16:34 ` tromey at sourceware dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-16324-4717-hqicC63qMl@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=gdb-prs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).