[Bug cli/17264] New: printing command stats for blank lines and comments is annoying

[Bug cli/17264] New: printing command stats for blank lines and comments is annoying

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17264

            Bug ID: 17264
           Summary: printing command stats for blank lines and comments is
                    annoying
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cli
          Assignee: dje at google dot com
          Reporter: dje at google dot com

The change to comment handling to not ignore them during reading, and instead
ignore them later, has an unintended side-effect of now having command stats
reported for them. [At least I think that's the cause for the change in
behaviour.]

@ruffy:gdb$ cat foo.gdb
mt set per on
set trace-commands on
pwd
# testing

echo 123\n
@ruffy:gdb$ ./gdb --batch -D ./data-directory -x foo.gdb
Command execution time: 0.000008 (cpu), 0.000008 (wall)
Space used: 2580480 (+0 for this command)
#symtabs: 0 (+0), #primary symtabs: 0 (+0), #blocks: 0 (+0)
+pwd
Working directory /g3/gnu/sourceware/main-gdb-git/b-master/obj64/gdb.
Command execution time: 0.000015 (cpu), 0.000020 (wall)
Space used: 2580480 (+0 for this command)
#symtabs: 0 (+0), #primary symtabs: 0 (+0), #blocks: 0 (+0)
Command execution time: 0.000002 (cpu), 0.000001 (wall) <<<<
Space used: 2580480 (+0 for this command) <<<<
#symtabs: 0 (+0), #primary symtabs: 0 (+0), #blocks: 0 (+0) <<<<
Command execution time: 0.000001 (cpu), 0.000002 (wall) <<<<
Space used: 2580480 (+0 for this command) <<<<
#symtabs: 0 (+0), #primary symtabs: 0 (+0), #blocks: 0 (+0) <<<<
+echo 123\n
123
Command execution time: 0.000013 (cpu), 0.000015 (wall)
Space used: 2580480 (+0 for this command)
#symtabs: 0 (+0), #primary symtabs: 0 (+0), #blocks: 0 (+0)

Patch in progress.
This should go in 7.8.1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/17264] printing command stats for blank lines and comments is annoying

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17264

--- Comment #1 from dje at google dot com ---
Huh.  It's not a change in behaviour, at least as far back as 7.6.
The behaviour is still annoying. :-)
Though there's less of a priority to put the patch in 7.8.1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/17264] printing command stats for blank lines and comments is annoying

[meator.dev at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17264

meator <meator.dev at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |meator.dev at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.