[Bug cli/17289] New: show/set record <TAB> completion

[Bug cli/17289] New: show/set record <TAB> completion

[dilyan.palauzov at aegee dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17289

            Bug ID: 17289
           Summary: show/set record <TAB> completion
           Product: gdb
           Version: 7.8
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cli
          Assignee: unassigned at sourceware dot org
          Reporter: dilyan.palauzov at aegee dot org

(gdb) show record
record btrace replay-memory-access:  Replay memory access is read-only.
record full insn-number-max:  Record/replay buffer limit is 200000.
record full memory-query:  Whether query if PREC cannot record memory change of
next instruction is off.
record full stop-at-limit:  Whether record/replay stops when record/replay
buffer becomes full is on.
function-call-history-size:  Number of functions to print in "record
function-call-history" is 10.
insn-number-max:  instruction-history-size:  Number of instructions to print in
"record instruction-history" is 10.
memory-query:  stop-at-limit:  (gdb)

I expect, that at the very end, the "show record" terminates with a new line
and the prompt appears on the start of the next line.  The last two lines look
pretty messy.

(gdb) show record <TAB>
btrace                      function-call-history-size
full                        instruction-history-size
(gdb) show record isns<TAB>   <- nothing happens.  I expect a completion to
insn-number-max
(gdb) show record insn-number-max
Record/replay buffer limit is 200000.

Likewise, <TAB>completion does not work for
show record instruction-history-size
show record memory-query
show record stop-at-limit   //but "show record st" produces correct output,
contrary to show record isns
set record memory-query
set record stop-at-limit

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/17289] show/set record <TAB> completion

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17289

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
This works correctly now.  I think Philippe's patches fixed this.

The issue here was that "insn-number-max" is actually
"show record full insn-number-max" -- so completion correctly didn't
work, but "show record" instead was confusingly printing it
as if it was a sub-option of "show record".

-- 
You are receiving this mail because:
You are on the CC list for the bug.