[Bug symtab/17559] confusion on what the result of find_pc_symtab is

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17559

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  34248c3af73049fe1f8b7a4b9eb7ae09f42eed95 (commit)
      from  2097ae2584c1018a7a58d93d9edd7f6d1d9654c8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=34248c3af73049fe1f8b7a4b9eb7ae09f42eed95

commit 34248c3af73049fe1f8b7a4b9eb7ae09f42eed95
Author: Doug Evans <xdje42@gmail.com>
Date:   Sat Nov 15 10:08:34 2014 -0800

    PR symtab/17559

    Basically the problem is that "symtab" is ambiguous.
    Is it the primary symtab (where we canonically think of
    blockvectors as being stored) or is it for a specific file
    (where each file's line table is stored) ?

    gdb_disassembly wants the symtab that contains the line table
    but is instead getting the primary symtab.

    gdb/ChangeLog:

        PR symtab/17559
        * symtab.c (find_pc_line_symtab): New function.
        * symtab.h (find_pc_line_symtab): Declare.
        * disasm.c (gdb_disassembly): Call find_pc_line_symtab instead of
        find_pc_symtab.
        * tui/tui-disasm.c (tui_set_disassem_content): Ditto.
        * tui/tui-hooks.c (tui_selected_frame_level_changed_hook): Ditto.
        * tui/tui-source.c (tui_vertical_source_scroll): Ditto.
        * tui/tui-win.c (make_visible_with_new_height): Ditto.
        * tui/tui-winsource.c (tui_horizontal_source_scroll): Ditto.
        (tui_display_main): Call find_pc_line_symtab instead of find_pc_line.

    gdb/testsuite/ChangeLog:

        PR symtab/17559
        * gdb.base/line-symtabs.exp: New file.
        * gdb.base/line-symtabs.c: New file.
        * gdb.base/line-symtabs.h: New file.

-----------------------------------------------------------------------

Summary of changes:
 gdb/ChangeLog                           |   14 +++++++++++++
 gdb/disasm.c                            |    5 +--
 gdb/symtab.c                            |   13 ++++++++++++
 gdb/symtab.h                            |    4 +++
 gdb/testsuite/ChangeLog                 |    7 ++++++
 gdb/testsuite/gdb.base/line-symtabs.c   |   25 +++++++++++++++++++++++
 gdb/testsuite/gdb.base/line-symtabs.exp |   33 +++++++++++++++++++++++++++++++
 gdb/testsuite/gdb.base/line-symtabs.h   |   24 ++++++++++++++++++++++
 gdb/tui/tui-disasm.c                    |    2 +-
 gdb/tui/tui-hooks.c                     |    2 +-
 gdb/tui/tui-source.c                    |    2 +-
 gdb/tui/tui-win.c                       |    2 +-
 gdb/tui/tui-winsource.c                 |   10 ++++----
 13 files changed, 131 insertions(+), 12 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/line-symtabs.c
 create mode 100644 gdb/testsuite/gdb.base/line-symtabs.exp
 create mode 100644 gdb/testsuite/gdb.base/line-symtabs.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.