[Bug symtab/17559] confusion on what the result of find_pc_symtab is

["xdje42 at gmail dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17559

--- Comment #4 from Doug Evans <xdje42 at gmail dot com> ---
This patch fixes my simple testcase.

diff --git a/gdb/disasm.c b/gdb/disasm.c
index 6ff3793..c3f99f1 100644
--- a/gdb/disasm.c
+++ b/gdb/disasm.c
@@ -410,13 +410,14 @@ gdb_disassembly (struct gdbarch *gdbarch, struct ui_out
*uiout,
   struct ui_file *stb = mem_fileopen ();
   struct cleanup *cleanups = make_cleanup_ui_file_delete (stb);
   struct disassemble_info di = gdb_disassemble_info (gdbarch, stb);
-  /* To collect the instruction outputted from opcodes.  */
+  struct symtab_and_line sal;
   struct symtab *symtab = NULL;
   struct linetable_entry *le = NULL;
   int nlines = -1;

   /* Assume symtab is valid for whole PC range.  */
-  symtab = find_pc_symtab (low);
+  sal = find_pc_line (low, 0);
+  symtab = sal.symtab;

   if (symtab != NULL && symtab->linetable != NULL)
     {

I think the thing to do, besides this (after some more testing), is rename
find_pc_symtab.
In my symtab reorg patch, find_pc_compunit works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.